Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2849023002: media: Update comments in video_capture_device_factory.h (Closed)

Created:
3 years, 7 months ago by jcliang
Modified:
3 years, 7 months ago
Reviewers:
chfremer
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, xjz+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Update comments in video_capture_device_factory.h We create the VideoCaptureDeviceFactory instance on the UI thread now. Update the comments accordingly. BUG=584797 TEST=None R=chfremer Review-Url: https://codereview.chromium.org/2849023002 Cr-Commit-Position: refs/heads/master@{#473422} Committed: https://chromium.googlesource.com/chromium/src/+/ae4f9843d8d5c48bf2d8e6674394bbd22674821e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/capture/video/video_capture_device_factory.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
chfremer
Sorry, I missed the notification about this CL. LGTM
3 years, 7 months ago (2017-05-18 15:45:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849023002/1
3 years, 7 months ago (2017-05-20 05:16:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849023002/1
3 years, 7 months ago (2017-05-20 05:16:31 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-20 06:44:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae4f9843d8d5c48bf2d8e6674394...

Powered by Google App Engine
This is Rietveld 408576698