Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2848993002: Make FrameSelection::SelectAll bail if 'selectstart' detaches frame (Closed)

Created:
3 years, 7 months ago by Xiaocheng
Modified:
3 years, 7 months ago
Reviewers:
tkent, xiaochengh, kojii
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make FrameSelection::SelectAll bail if 'selectstart' detaches frame BUG=715387 TEST=LayoutTests/editing/selection/selectstart_detaches_frame.html Review-Url: https://codereview.chromium.org/2848993002 Cr-Commit-Position: refs/heads/master@{#468292} Committed: https://chromium.googlesource.com/chromium/src/+/73fe6ba4ceb2db91a43ee2305f69ffde08001f62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/editing/selection/selectstart_detaches_frame.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Xiaocheng
PTAL, as both yosin@ and tkent@ are OOO...
3 years, 7 months ago (2017-04-29 01:01:47 UTC) #5
kojii
tkent@, PTAL, and here.
3 years, 7 months ago (2017-05-01 01:58:18 UTC) #9
tkent
lgtm
3 years, 7 months ago (2017-05-01 02:25:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848993002/1
3 years, 7 months ago (2017-05-01 02:30:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/373625)
3 years, 7 months ago (2017-05-01 03:45:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848993002/1
3 years, 7 months ago (2017-05-01 04:39:06 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 05:43:11 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73fe6ba4ceb2db91a43ee2305f69...

Powered by Google App Engine
This is Rietveld 408576698