MD Settings: convert paper-icon-button to paper-icon-button-light.

ui/webui/resources/cr_elements/shared_style_css.html

Index: ui/webui/resources/cr_elements/shared_style_css.html
diff --git a/ui/webui/resources/cr_elements/shared_style_css.html b/ui/webui/resources/cr_elements/shared_style_css.html
index 6199ea4778ee9189c4ef4b66699812420ab43b3c..e86198409cc37cd9efe35f5501e3662ceb87d090 100644
--- a/ui/webui/resources/cr_elements/shared_style_css.html
+++ b/ui/webui/resources/cr_elements/shared_style_css.html
@@ -1,12 +1,13 @@
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/cr_elements/shared_vars_css.html">
 <link rel="import" href="hidden_style_css.html">
+<link rel="import" href="cr_icons_css.html">
 
 <!-- Common styles for Material Design WebUI. Included directly in
   settings_shared_css.html. -->
 <dom-module id="cr-shared-style">
   <template>
-    <style include="cr-hidden-style">
+    <style include="cr-hidden-style cr-icons">
       :host-context([dir=rtl]) button[is='paper-icon-button-light'] {
         transform: scaleX(-1);  /* Flip on the X axis (aka mirror). */
       }
@@ -49,8 +50,7 @@
       }
 
       button[is='paper-icon-button-light'] {
-        -webkit-margin-end: var(--cr-icon-ripple-margin);
-        -webkit-margin-start: 16px;
+        @apply(--cr-paper-icon-button-margin);

[dschuyler, 2017/06/07 23:21:22]

This change allows preceding elements in a row to get too close to the button
(which will regress a recent bug fix).

[scottchen, 2017/06/08 22:13:15]

This value defaults to 16px, so that 16px will be there unless the custom
element in action really needs to override the front margin (i.e.
http://imgur.com/a/IjK5j to fix misalignment issue).

EDIT:
We addressed this offline, the conclusion was we always want the spacing before
the icon-button based on spec. Will make a separate issue to fix misalignment.

         background-position: center;
         background-repeat: no-repeat;
         background-size: var(--cr-icon-size);
@@ -59,32 +59,11 @@
         width: var(--cr-icon-ripple-size);
       }
 
-      button[is='paper-icon-button-light'].subpage-arrow {
-        background-image: url(chrome://resources/images/arrow_right.svg);
-      }
-
-      button[is='paper-icon-button-light'].icon-cancel {
-        background-image: url(chrome://resources/images/icon_cancel.svg);
-      }
-
-      button[is='paper-icon-button-light'].icon-cancel-toolbar {
-        background-image:
-            url(chrome://resources/images/icon_cancel_toolbar.svg);
-      }
-
-      button[is='paper-icon-button-light'].icon-external {
-        background-image: url(chrome://resources/images/open_in_new.svg);
-      }
-
       .subpage-arrow,
       .icon-external {
         display: none;
       }
 
-      paper-icon-button.subpage-arrow {
-        background-image: url(../images/arrow_right.svg);
-      }
-
       [actionable] :-webkit-any(.subpage-arrow, .icon-external),
       [actionable]:-webkit-any(.subpage-arrow, .icon-external) {
         display: block;