chrome/browser/resources/settings/search_engines_page/search_engine_entry.js - Issue 2848973003: MD Settings: convert paper-icon-button to paper-icon-button-light.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

Issue 2848973003: MD Settings: convert paper-icon-button to paper-icon-button-light. (Closed)

Patch Set: feedback Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/internet_page/internet_subpage.html ('K') | « chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js ('k') | chrome/browser/resources/settings/settings_icons_css.html » ('j') | chrome/browser/resources/settings/settings_icons_css.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

index 20b2e37046dbf7f39c60f20f1c309cc391d7d89d..735b01e77e1d8c6bec7f9b1f9ee1d575275b75af 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

@@ -85,9 +85,8 @@ Polymer({

/** @private */

onDotsTap_: function() {

- /** @type {!CrActionMenuElement} */ (

- this.$$('dialog[is=cr-action-menu]')).showAt(

- assert(this.$$('paper-icon-button')));

+ /** @type {!CrActionMenuElement} */ (this.$$('dialog[is=cr-action-menu]'))

+ .showAt(assert(this.$$('button[is="paper-icon-button-light"]')));

/**

@@ -106,7 +105,8 @@ Polymer({

// previous dialog's contents are cleared.

dialog.addEventListener('close', function() {

this.showEditSearchEngineDialog_ = false;

- cr.ui.focusWithoutInk(assert(this.$$('paper-icon-button')));

+ cr.ui.focusWithoutInk(assert(this.$$(

+ 'button[is="paper-icon-button-light"]')));

}.bind(this));