Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3606)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_subpage.html

Issue 2848973003: MD Settings: convert paper-icon-button to paper-icon-button-light. (Closed)
Patch Set: feedback Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/internet_subpage.html
diff --git a/chrome/browser/resources/settings/internet_page/internet_subpage.html b/chrome/browser/resources/settings/internet_page/internet_subpage.html
index 9534330c1dc229e6983d8c3cd72805e6ab5b5d15..16a640b669c83bc8b6d02f380010a4c50a614b43 100644
--- a/chrome/browser/resources/settings/internet_page/internet_subpage.html
+++ b/chrome/browser/resources/settings/internet_page/internet_subpage.html
@@ -3,7 +3,7 @@
<link rel="import" href="chrome://resources/cr_elements/network/cr_network_list.html">
<link rel="import" href="chrome://resources/html/i18n_behavior.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-flex-layout-classes.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/paper-toggle-button.html">
<link rel="import" href="../settings_shared_css.html">
@@ -55,11 +55,12 @@
'$i18nPolymer{deviceOn}', '$i18nPolymer{deviceOff}')]]
</div>
<!-- The add button in this row is only shown for WiFi networks. -->
- <paper-icon-button id="addButton" icon="settings:add-wifi"
+ <button is="paper-icon-button-light" id="addButton"
hidden$="[[!showAddButton_(deviceState, globalPolicy)]]"
aria-label="$i18n{internetAddWiFi}"
on-tap="onAddButtonTap_" tabindex$="[[tabindex]]">
- </paper-icon-button>
+ <iron-icon icon="settings:add-wifi"></iron-icon>
dschuyler 2017/06/07 23:21:21 Thanks for removing iron-icon in other files in th
scottchen 2017/06/08 22:13:15 Missed this one, nice catch.
+ </button>
<paper-toggle-button id="deviceEnabledButton"
aria-label$="[[getToggleA11yString_(deviceState)]]"
checked="[[deviceIsEnabled_(deviceState)]]"
@@ -84,10 +85,11 @@
<div class="vpn-header layout horizontal center"
hidden$="[[!isEqual_('VPN', deviceState.Type)]]">
<div class="flex">$i18n{networkVpnBuiltin}</div>
- <paper-icon-button icon="settings:add-circle"
+ <button is="paper-icon-button-light"
aria-label="$i18n{internetAddVPN}"
on-tap="onAddButtonTap_" tabindex$="[[tabindex]]">
- </paper-icon-button>
+ <iron-icon icon="settings:add-circle"></iron-icon>
+ </button>
</div>
<!-- List of networks or 'None'. -->
@@ -106,10 +108,11 @@
<div id="[[item.ProviderName]]"
class="vpn-header layout horizontal center">
<div class="flex">[[item.ProviderName]]</div>
- <paper-icon-button icon="settings:add-circle"
+ <button is="paper-icon-button-light"
aria-label$="[[getAddThirdPartyVpnA11yString_(item)]]"
on-tap="onAddThirdPartyVpnTap_" tabindex$="[[tabindex]]">
- </paper-icon-button>
+ <iron-icon icon="settings:add-circle"></iron-icon>
+ </button>
</div>
<cr-network-list show-buttons
hidden$="[[!haveThirdPartyVpnNetwork_(thirdPartyVpns_, item)]]"

Powered by Google App Engine
This is Rietveld 408576698