chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html - Issue 2848973003: MD Settings: convert paper-icon-button to paper-icon-button-light.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

Issue 2848973003: MD Settings: convert paper-icon-button to paper-icon-button-light. (Closed)

Patch Set: move more icons to classes Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html » ('j') | chrome/browser/resources/settings/people_page/camera.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

index febfe0a5fc11cb267fdc3e92725839c79bfb2c4f..c71608f26fa39179bc8e2c7b01d01b8e85bdc89c 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html

@@ -1,8 +1,9 @@

+<link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">

dschuyler 2017/06/06 18:58:39 Is this still needed?

scottchen 2017/06/06 22:33:11 Nope, removing.

-<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">

+<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">

@@ -55,12 +56,12 @@

value="[[getPassword_(item, password)]]" readonly

on-tap="onReadonlyInputTap_">

</paper-input>

- <paper-icon-button id="showPasswordButton"

- hidden$="[[item.federationText]]"

- icon="settings:visibility" on-tap="onShowPasswordButtonTap_"

+ <button is="paper-icon-button-light" id="showPasswordButton"

+ class="icon-visibility" hidden$="[[item.federationText]]"

+ on-tap="onShowPasswordButtonTap_"

title="[[showPasswordTitle_(password,

'$i18nPolymer{hidePassword}','$i18nPolymer{showPassword}')]]">

- </paper-icon-button>

+ </button>

</div>