Do not send pings for anchor elements in MHTML pages

Do not send pings for anchor elements in MHTML pages

Ping attribute is also not saved in MHTML serialization.

BUG=715860
TEST=test added

Review-Url: https://codereview.chromium.org/2848953003
Cr-Commit-Position: refs/heads/master@{#469808}
Committed: https://chromium.googlesource.com/chromium/src/+/417805f68c1f86ddc1c69229fd40fedb62086a55

[jianli, 2017-04-28 22:00:41]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 22:01:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jianli, 2017-04-28 22:02:26]

The CQ bit was checked by jianli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 22:03:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jianli, 2017-04-28 22:04:07]

jianli@chromium.org changed reviewers:
+ mkwst@chromium.org

[commit-bot: I haz the power, 2017-04-28 23:43:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 23:43:48]

Dry run: This issue passed the CQ dry run.

[Mike West, 2017-05-02 07:43:21]

https://codereview.chromium.org/2848953003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp (right):

https://codereview.chromium.org/2848953003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp:311: return;
What about other things that go through `PingLoader`? (CSP violations, XSS
Auditor violations, Beacon) I guess you're blocking those as well, but it might
make your checks a little more robust to do them there (e.g. in
`SendBeaconCommon`:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/loader/Pi...).

[jianli, 2017-05-03 21:15:17]

https://codereview.chromium.org/2848953003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp (right):

https://codereview.chromium.org/2848953003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp:311: return;
On 2017/05/02 07:43:21, Mike West wrote:
> What about other things that go through `PingLoader`? (CSP violations, XSS
> Auditor violations, Beacon) I guess you're blocking those as well, but it
might
> make your checks a little more robust to do them there (e.g. in
> `SendBeaconCommon`:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/loader/Pi...).

I don't think other types of pings/beacons can be triggered from loaded MHTML:
* "report-uri" in Content-Security-Policy cannot be put in meta tag. Thus CSP
violations will not be sent.
* XSS auditor reports can only be triggered by providing XSS protection header
from server. Thus MHTML will not have this problem.
* Navigator.sendBeacon can only be called from the script. Since the script
execution is disabled in MHTML, this will not be likely.

It seems that we only have problem with anchor pings. So I don't want to
complicate PingLoader logic.

[Mike West, 2017-05-04 06:35:46]

LGTM. I suppose we can revisit the implementation if/when those constraints
change.

[jianli, 2017-05-05 19:18:45]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2017-05-05 19:19:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 19:25:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 19:25:26]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jianli, 2017-05-05 20:17:57]

The CQ bit was checked by jianli@chromium.org

[jianli, 2017-05-05 20:17:58]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2848953003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-05 20:18:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 23:46:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494015477959170,
"parent_rev": "0894550fc7a4d5bd11d5b9992383a701b6177428", "commit_rev":
"417805f68c1f86ddc1c69229fd40fedb62086a55"}

[commit-bot: I haz the power, 2017-05-05 23:46:10]

Description was changed from

==========
Do not send pings for anchor elements in MHTML pages

Ping attribute is also not saved in MHTML serialization.

BUG=715860
TEST=test added
==========

to

==========
Do not send pings for anchor elements in MHTML pages

Ping attribute is also not saved in MHTML serialization.

BUG=715860
TEST=test added

Review-Url: https://codereview.chromium.org/2848953003
Cr-Commit-Position: refs/heads/master@{#469808}
Committed:
https://chromium.googlesource.com/chromium/src/+/417805f68c1f86ddc1c69229fd40...
==========

[commit-bot: I haz the power, 2017-05-05 23:46:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/417805f68c1f86ddc1c69229fd40...