Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2848953002: [Mac] Fix Omnibox decoration accessibility views in RTL (Closed)

Created:
3 years, 7 months ago by lgrey
Modified:
3 years, 7 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix Omnibox decoration accessibility views in RTL BUG=715627 Review-Url: https://codereview.chromium.org/2848953002 Cr-Commit-Position: refs/heads/master@{#468115} Committed: https://chromium.googlesource.com/chromium/src/+/18d20ce633237ad74a62ed025c6f2f91c5f7182e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
lgrey
PTAL :)
3 years, 7 months ago (2017-04-28 18:22:16 UTC) #2
Elly Fong-Jones
lgtm
3 years, 7 months ago (2017-04-28 18:59:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848953002/1
3 years, 7 months ago (2017-04-28 20:16:40 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 20:36:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18d20ce633237ad74a62ed025c6f...

Powered by Google App Engine
This is Rietveld 408576698