[infra] Assembles the SDK using GN rather than create_sdk.py

[infra] Assembles the SDK using GN rather than create_sdk.py

This has a few advantages:
- We can track dependencies more precisely
- ninja can assemble things in parallel as they're ready rather than
  sequentially all at once.
- It is easier to customize SDKs depending on target platform, e.g.
  Fuchsia.

This CL also has a number of cleanups:
- Defining is_fuchsia and is_fuchsia host so we don't always have to check
- Piping through toolchain overrides in more places
- Fixing bugs in copy_tree.py, not using list_files.py, which is broken on Windows

related #29558

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/81e428fd39032fb23997c04c6681f8e5fcda9105

[zra, 2017-05-09 18:40:44]

Description was changed from

==========
[infra] Assembles the SDK using GN rather than create_sdk.py

This has a few advantages:
- We can track dependencies more precisely
- ninja can assemble things in parallel as they're ready rather than
  sequentially all at once.
- It is easier to customize SDKs depending on target platform, e.g.
  Fuchsia.
==========

to

==========
[infra] Assembles the SDK using GN rather than create_sdk.py

This has a few advantages:
- We can track dependencies more precisely
- ninja can assemble things in parallel as they're ready rather than
  sequentially all at once.
- It is easier to customize SDKs depending on target platform, e.g.
  Fuchsia.

This CL also has a number of cleanups:
- Defining is_fuchsia and is_fuchsia host so we don't always have to check
- Piping through toolchain overrides in more places
- Fixing bugs in copy_tree.py, not using list_files.py
==========

[zra, 2017-05-09 20:23:04]

Description was changed from

==========
[infra] Assembles the SDK using GN rather than create_sdk.py

This has a few advantages:
- We can track dependencies more precisely
- ninja can assemble things in parallel as they're ready rather than
  sequentially all at once.
- It is easier to customize SDKs depending on target platform, e.g.
  Fuchsia.

This CL also has a number of cleanups:
- Defining is_fuchsia and is_fuchsia host so we don't always have to check
- Piping through toolchain overrides in more places
- Fixing bugs in copy_tree.py, not using list_files.py
==========

to

==========
[infra] Assembles the SDK using GN rather than create_sdk.py

This has a few advantages:
- We can track dependencies more precisely
- ninja can assemble things in parallel as they're ready rather than
  sequentially all at once.
- It is easier to customize SDKs depending on target platform, e.g.
  Fuchsia.

This CL also has a number of cleanups:
- Defining is_fuchsia and is_fuchsia host so we don't always have to check
- Piping through toolchain overrides in more places
- Fixing bugs in copy_tree.py, not using list_files.py, which is broken on
Windows
==========

[zra, 2017-05-10 20:52:59]

zra@google.com changed reviewers:
+ asiva@google.com, whesse@google.com

[zra, 2017-05-11 15:40:01]

Description was changed from

==========
[infra] Assembles the SDK using GN rather than create_sdk.py

This has a few advantages:
- We can track dependencies more precisely
- ninja can assemble things in parallel as they're ready rather than
  sequentially all at once.
- It is easier to customize SDKs depending on target platform, e.g.
  Fuchsia.

This CL also has a number of cleanups:
- Defining is_fuchsia and is_fuchsia host so we don't always have to check
- Piping through toolchain overrides in more places
- Fixing bugs in copy_tree.py, not using list_files.py, which is broken on
Windows
==========

to

==========
[infra] Assembles the SDK using GN rather than create_sdk.py

This has a few advantages:
- We can track dependencies more precisely
- ninja can assemble things in parallel as they're ready rather than
  sequentially all at once.
- It is easier to customize SDKs depending on target platform, e.g.
  Fuchsia.

This CL also has a number of cleanups:
- Defining is_fuchsia and is_fuchsia host so we don't always have to check
- Piping through toolchain overrides in more places
- Fixing bugs in copy_tree.py, not using list_files.py, which is broken on
Windows

related #29558
==========

[zra, 2017-05-11 18:12:35]

This is ready for review.

https://codereview.chromium.org/2848943003/diff/200001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/2848943003/diff/200001/BUILD.gn#oldcode129
BUILD.gn:129: if (dart_build_fuchsia_test_image) {
This no longer needs to be guarded as the Fuchsia build is no longer building
all targets indiscriminately.

[Bill Hesse, 2017-05-17 10:41:10]

LGTM. Maybe this could be passed by a GN expert on the Chromium team, to see if
this is the correct idomatic way to do all these things, or if there are better
ways we don't know about.

https://codereview.chromium.org/2848943003/diff/240001/tools/create_sdk.py
File tools/create_sdk.py (left):

https://codereview.chromium.org/2848943003/diff/240001/tools/create_sdk.py#ol...
tools/create_sdk.py:10: #
I hate to lose this documentation of the sdk directory structure.  Can we put it
somewhere else?

[zra, 2017-05-20 21:53:04]

These rules are essentially just copying files, so I doubt we'll learn any
helpful tricks from a Chromium GN expert.

https://codereview.chromium.org/2848943003/diff/240001/tools/create_sdk.py
File tools/create_sdk.py (left):

https://codereview.chromium.org/2848943003/diff/240001/tools/create_sdk.py#ol...
tools/create_sdk.py:10: #
On 2017/05/17 10:41:10, Bill Hesse wrote:
> I hate to lose this documentation of the sdk directory structure.  Can we put
it
> somewhere else?

Moved to sdk/BUILD.gn

[zra, 2017-05-21 06:30:12]

Description was changed from

==========
[infra] Assembles the SDK using GN rather than create_sdk.py

This has a few advantages:
- We can track dependencies more precisely
- ninja can assemble things in parallel as they're ready rather than
  sequentially all at once.
- It is easier to customize SDKs depending on target platform, e.g.
  Fuchsia.

This CL also has a number of cleanups:
- Defining is_fuchsia and is_fuchsia host so we don't always have to check
- Piping through toolchain overrides in more places
- Fixing bugs in copy_tree.py, not using list_files.py, which is broken on
Windows

related #29558
==========

to

==========
[infra] Assembles the SDK using GN rather than create_sdk.py

This has a few advantages:
- We can track dependencies more precisely
- ninja can assemble things in parallel as they're ready rather than
  sequentially all at once.
- It is easier to customize SDKs depending on target platform, e.g.
  Fuchsia.

This CL also has a number of cleanups:
- Defining is_fuchsia and is_fuchsia host so we don't always have to check
- Piping through toolchain overrides in more places
- Fixing bugs in copy_tree.py, not using list_files.py, which is broken on
Windows

related #29558

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/81e428fd39032fb23997c04c6681f8e5fcda9105
==========

[zra, 2017-05-21 06:30:14]

Committed patchset #20 (id:360001) manually as
81e428fd39032fb23997c04c6681f8e5fcda9105 (presubmit successful).