Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: build/toolchain/mac/BUILD.gn

Issue 2848943003: [infra] Assembles the SDK using GN rather than create_sdk.py (Closed)
Patch Set: Move copy_dev_compiler_tools out of the default full SDK build Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/linux/BUILD.gn ('k') | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/mac/BUILD.gn
diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn
index 811ab467f879afbaa0cd5f2935c3291d5578abd8..c26364fdac74e79450c218b2a5067441986d66ab 100644
--- a/build/toolchain/mac/BUILD.gn
+++ b/build/toolchain/mac/BUILD.gn
@@ -171,15 +171,29 @@ template("mac_toolchain") {
}
tool("link") {
- outfile = "{{root_out_dir}}/{{target_output_name}}{{output_extension}}"
+ exename = "{{target_output_name}}{{output_extension}}"
+ outfile = "{{root_out_dir}}/$exename"
rspfile = "$outfile.rsp"
+ if (defined(invoker.strip)) {
+ stripped_outfile = "{{root_out_dir}}/exe.stripped/$exename"
+ }
+
command = "$ld $sysroot_flags $toolchain_flags {{ldflags}} -Xlinker -rpath -Xlinker @executable_path/Frameworks -o $outfile -Wl,-filelist,$rspfile {{solibs}} {{libs}}"
+ if (defined(invoker.strip)) {
+ strip = invoker.strip
+ strip_command = "${strip} -x -o $stripped_outfile $outfile"
+ command += " && " + strip_command
+ }
+
description = "LINK $outfile"
rspfile_content = "{{inputs_newline}}"
outputs = [
outfile,
]
+ if (defined(invoker.strip)) {
+ outputs += [ stripped_outfile ]
+ }
}
tool("stamp") {
@@ -216,6 +230,7 @@ mac_toolchain("clang_x64") {
cc = "${goma_prefix}$prefix/clang"
cxx = "${goma_prefix}$prefix/clang++"
ld = cxx
+ strip = "${prefix}/strip"
is_clang = true
sysroot_flags = "-isysroot $mac_sdk_path -mmacosx-version-min=$mac_sdk_min"
}
@@ -229,6 +244,7 @@ mac_toolchain("clang_x86") {
cc = "${goma_prefix}$prefix/clang"
cxx = "${goma_prefix}$prefix/clang++"
ld = cxx
+ strip = "${prefix}/strip"
is_clang = true
sysroot_flags = "-isysroot $mac_sdk_path -mmacosx-version-min=$mac_sdk_min"
}
« no previous file with comments | « build/toolchain/linux/BUILD.gn ('k') | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698