Test FindBar audible alerts.

Test FindBar audible alerts.

BUG=682299
Review-Url: https://codereview.chromium.org/2848883005
Cr-Commit-Position: refs/heads/master@{#469344}
Committed: https://chromium.googlesource.com/chromium/src/+/ea0b89eaf580c7edfae3f61f137dde6c9312bee1

[Sigurður Ásgeirsson, 2017-04-28 19:46:24]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 19:47:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sigurður Ásgeirsson, 2017-04-28 19:47:13]

Description was changed from

==========
Test FindBar audible alerts.

BUG=682299
==========

to

==========
Test FindBar audible alerts.

BUG=682299
==========

[Sigurður Ásgeirsson, 2017-04-28 19:47:13]

siggi@chromium.org changed reviewers:
+ finnur@chromium.org

[Sigurður Ásgeirsson, 2017-04-28 19:48:04]

Finnur, please take a quick look, see how you like this approach? I still need
to figure out how to test the frame add/remove case.

[commit-bot: I haz the power, 2017-04-28 21:28:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 21:28:55]

Dry run: This issue passed the CQ dry run.

[Finnur, 2017-05-02 12:50:38]

LGTM

[Sigurður Ásgeirsson, 2017-05-02 14:03:37]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 14:03:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sigurður Ásgeirsson, 2017-05-02 14:07:31]

Thanks - I added testing for the other noisome ding cases. One more quick look?

[Sigurður Ásgeirsson, 2017-05-02 15:03:39]

The CQ bit was checked by siggi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 15:03:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 15:56:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 15:56:19]

Dry run: This issue passed the CQ dry run.

[Finnur, 2017-05-03 10:43:47]

LGTM

[Sigurður Ásgeirsson, 2017-05-03 11:58:24]

The CQ bit was checked by siggi@chromium.org

[commit-bot: I haz the power, 2017-05-03 11:58:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 12:07:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 12:07:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sigurður Ásgeirsson, 2017-05-03 12:38:43]

siggi@chromium.org changed reviewers:
+ sky@chromium.org

[Sigurður Ásgeirsson, 2017-05-03 12:38:44]

Scott for owners pretty please, as Peter's OOO.

[sky, 2017-05-04 04:16:36]

LGTM

https://codereview.chromium.org/2848883005/diff/40001/chrome/browser/ui/find_...
File chrome/browser/ui/find_bar/find_bar_host_browsertest.cc (right):

https://codereview.chromium.org/2848883005/diff/40001/chrome/browser/ui/find_...
chrome/browser/ui/find_bar/find_bar_host_browsertest.cc:328: // a different page
and verifies this doesn't cause an extrenous dings.
an -> any
extrenous -> extraneous

[Sigurður Ásgeirsson, 2017-05-04 13:16:17]

The CQ bit was checked by siggi@chromium.org

[Sigurður Ásgeirsson, 2017-05-04 13:16:18]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2848883005/#ps60001
(title: "Address Scott's comment.")

[commit-bot: I haz the power, 2017-05-04 13:16:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sigurður Ásgeirsson, 2017-05-04 13:46:54]

Thanks.

https://codereview.chromium.org/2848883005/diff/40001/chrome/browser/ui/find_...
File chrome/browser/ui/find_bar/find_bar_host_browsertest.cc (right):

https://codereview.chromium.org/2848883005/diff/40001/chrome/browser/ui/find_...
chrome/browser/ui/find_bar/find_bar_host_browsertest.cc:328: // a different page
and verifies this doesn't cause an extrenous dings.
On 2017/05/04 04:16:36, sky wrote:
> an -> any
> extrenous -> extraneous

Done.

[commit-bot: I haz the power, 2017-05-04 14:35:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 14:35:51]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Sigurður Ásgeirsson, 2017-05-04 14:52:58]

The CQ bit was checked by siggi@chromium.org

[commit-bot: I haz the power, 2017-05-04 14:54:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 15:33:40]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493909578696650,
"parent_rev": "808626a965952b3b50656b1fc57f995964506ec3", "commit_rev":
"ea0b89eaf580c7edfae3f61f137dde6c9312bee1"}

[commit-bot: I haz the power, 2017-05-04 15:33:49]

Description was changed from

==========
Test FindBar audible alerts.

BUG=682299
==========

to

==========
Test FindBar audible alerts.

BUG=682299

Review-Url: https://codereview.chromium.org/2848883005
Cr-Commit-Position: refs/heads/master@{#469344}
Committed:
https://chromium.googlesource.com/chromium/src/+/ea0b89eaf580c7edfae3f61f137d...
==========

[commit-bot: I haz the power, 2017-05-04 15:33:51]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ea0b89eaf580c7edfae3f61f137d...