Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2848833002: webkitpy: Poll xvfb while checking with xdpyinfo. (Closed)

Created:
3 years, 7 months ago by mithro
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, qyearsley
CC:
qyearsley, blink-reviews, chromium-reviews, jeffcarp, mcgreevy
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Poll xvfb while checking with xdpyinfo. If xvfb dies or fails to start correctly while checking xdpyinfo, we should exit straight away rather than continuing to try and probe with xdpyinfo and waiting to time out. BUG=708681, 713597 Review-Url: https://codereview.chromium.org/2848833002 Cr-Commit-Position: refs/heads/master@{#469274} Committed: https://chromium.googlesource.com/chromium/src/+/c2fe004639a9a21fff08b6de088f052a0c5060b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py View 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mithro
3 years, 7 months ago (2017-04-28 06:19:38 UTC) #2
Dirk Pranke
lgtm
3 years, 7 months ago (2017-05-04 00:55:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848833002/1
3 years, 7 months ago (2017-05-04 03:52:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c2fe004639a9a21fff08b6de088f052a0c5060b8
3 years, 7 months ago (2017-05-04 05:24:07 UTC) #12
qyearsley
3 years, 7 months ago (2017-05-08 17:21:55 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698