Add DCHECK() to check ApplyStyleCommand::DoApply() to work on non-null range

Add DCHECK() to check ApplyStyleCommand::DoApply() to work on non-null range

This patch add DCHECK into |ApplyStyleCommand::DoApply()| to verify that we
don't apply |ApplyStyleCommand| to empty range to detect redundant command
execution for improving code health.

Actually, |ApplyStyleCommand::DoApply()| doesn't work with empty range, it
causes DCHECK for |Position.IsNull()| in |ComparePositions()|.

BUG=714311
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2848823002
Cr-Commit-Position: refs/heads/master@{#468077}
Committed: https://chromium.googlesource.com/chromium/src/+/4109e96377e75873e2e92308464313c0ff8f8008

[yosin_UTC9, 2017-04-28 05:05:41]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[yosin_UTC9, 2017-04-28 05:05:52]

Description was changed from

==========
2017-04-28T14:02:57

BUG=

2017-04-28T14:02:51
==========

to

==========
Add DCHECK() to check ApplyStyleCommand::DoApply() to work on non-null range

TBD


BUG=714311
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2017-04-28 05:06:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-04-28 05:39:52]

Description was changed from

==========
Add DCHECK() to check ApplyStyleCommand::DoApply() to work on non-null range

TBD


BUG=714311
TEST=n/a; no behavior changes
==========

to

==========
Add DCHECK() to check ApplyStyleCommand::DoApply() to work on non-null range

This patch add DCHECK into |ApplyStyleCommand::DoApply()| to verify that we
don't apply |ApplyStyleCommand| to empty range to detect redundant command
execution for improving code health.

Actually, |ApplyStyleCommand::DoApply()| doesn't work with empty range, it
causes DCHECK for |Position.IsNull()| in |ComparePositions()|.

BUG=714311
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2017-04-28 06:38:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 06:38:38]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-04-28 07:22:14]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-04-28 07:22:14]

PTAL

Please click [Commit] button since I'm OOO until May 8.
Thanks!

[Xiaocheng, 2017-04-28 18:42:09]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-04-28 18:42:09]

lgtm

[commit-bot: I haz the power, 2017-04-28 18:43:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 18:55:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493404929246780, "parent_rev":
"32dd23efdd4e557eddca40dc0f5bbb8c4e2ab5cc", "commit_rev":
"4109e96377e75873e2e92308464313c0ff8f8008"}

[commit-bot: I haz the power, 2017-04-28 18:55:37]

Description was changed from

==========
Add DCHECK() to check ApplyStyleCommand::DoApply() to work on non-null range

This patch add DCHECK into |ApplyStyleCommand::DoApply()| to verify that we
don't apply |ApplyStyleCommand| to empty range to detect redundant command
execution for improving code health.

Actually, |ApplyStyleCommand::DoApply()| doesn't work with empty range, it
causes DCHECK for |Position.IsNull()| in |ComparePositions()|.

BUG=714311
TEST=n/a; no behavior changes
==========

to

==========
Add DCHECK() to check ApplyStyleCommand::DoApply() to work on non-null range

This patch add DCHECK into |ApplyStyleCommand::DoApply()| to verify that we
don't apply |ApplyStyleCommand| to empty range to detect redundant command
execution for improving code health.

Actually, |ApplyStyleCommand::DoApply()| doesn't work with empty range, it
causes DCHECK for |Position.IsNull()| in |ComparePositions()|.

BUG=714311
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2848823002
Cr-Commit-Position: refs/heads/master@{#468077}
Committed:
https://chromium.googlesource.com/chromium/src/+/4109e96377e75873e2e923084643...
==========

[commit-bot: I haz the power, 2017-04-28 18:55:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4109e96377e75873e2e923084643...