Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2848793002: Revert of Only do Smart Select if one word is selected. (Closed)

Created:
3 years, 7 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 7 months ago
Reviewers:
Tima Vaisburd, amaralp
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Only do Smart Select if one word is selected. (patchset #4 id:60001 of https://codereview.chromium.org/2838023002/ ) Reason for revert: Null pointer crash http://crbug.com/715526 BUG=715526 Original issue's description: > Only do Smart Select if one word is selected. > > There is a bug where after "Select All" Smart Select will suggest a different > (smaller) selection. This CL checks if the selection only has one word. Since > longpress/double tap only selects one word, if we have multiple words we can assume > it comes from "Select All" and not do Smart Select. > > BUG=714106 > > Review-Url: https://codereview.chromium.org/2838023002 > Cr-Commit-Position: refs/heads/master@{#466856} > Committed: https://chromium.googlesource.com/chromium/src/+/03f5058e764e8b2b01d571f29426075a83f6049b TBR=timav@chromium.org,amaralp@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=714106 Review-Url: https://codereview.chromium.org/2848793002 Cr-Commit-Position: refs/heads/master@{#467870} Committed: https://chromium.googlesource.com/chromium/src/+/4bceb9805881b8c25d39efe3c94b0c5da714a556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
aelias_OOO_until_Jul13
Created Revert of Only do Smart Select if one word is selected.
3 years, 7 months ago (2017-04-28 02:54:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848793002/1
3 years, 7 months ago (2017-04-28 02:55:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848793002/1
3 years, 7 months ago (2017-04-28 03:25:58 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 03:26:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4bceb9805881b8c25d39efe3c94b...

Powered by Google App Engine
This is Rietveld 408576698