Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2848783002: [Merge to M59]Open system menu when click the status tray with volume popup opened. (Closed)

Created:
3 years, 7 months ago by xiaoyinh(OOO Sep 11-29)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to M59]Open system menu when click the status tray with volume popup opened. Merge to M59 3071 on behalf of minch@. Should open the system menu with one click of the status tray when a popup detailed view is visible. This is a regression issue related to https://codereview.chromium.org/2784163003/ BUG=711330 TBR=tdanderson@chromium.org, xiaoyinh@chromium.org Review-Url: https://codereview.chromium.org/2818183002 Cr-Commit-Position: refs/heads/master@{#465801} (cherry picked from commit 444e30cbb5d2bc60ea021b2405a6cfeea17ca14c) Review-Url: https://codereview.chromium.org/2848783002 . Cr-Commit-Position: refs/branch-heads/3071@{#279} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/3062212915d785dc84b5a695f05e131f95fda280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -31 lines) Patch
M ash/system/tray/system_tray.h View 2 chunks +13 lines, -13 lines 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
xiaoyinh(OOO Sep 11-29)
Committed patchset #1 (id:1) manually as 3062212915d785dc84b5a695f05e131f95fda280 (presubmit successful).
3 years, 7 months ago (2017-04-28 01:27:19 UTC) #2
tdanderson
3 years, 7 months ago (2017-04-28 16:40:17 UTC) #3
Message was sent while issue was closed.
On 2017/04/28 01:27:19, xiaoyinh wrote:
> Committed patchset #1 (id:1) manually as
> 3062212915d785dc84b5a695f05e131f95fda280 (presubmit successful).

lgtm

Powered by Google App Engine
This is Rietveld 408576698