Forward capturer id from desktop process to network process

Forward capturer id from desktop process to network process

Updates of message, proxy and agent are needed to forward capturer id to the
network process and eventually to the client.

BUG=chromium:679523, chromium:650926
Review-Url: https://codereview.chromium.org/2848753002
Cr-Commit-Position: refs/heads/master@{#467902}
Committed: https://chromium.googlesource.com/chromium/src/+/a1336afb916a5ea783cf76454f8804ac12709624

[Hzj_jie, 2017-04-28 00:08:20]

Description was changed from

==========
Forward capturer id from desktop process to network process

Updates of message, proxy and agent are needed to forward capturer id to the
network process and eventually to the client.

BUG=chromium:679523, chromium:650926
==========

to

==========
Forward capturer id from desktop process to network process

Updates of message, proxy and agent are needed to forward capturer id to the
network process and eventually to the client.

BUG=chromium:679523, chromium:650926
==========

[Hzj_jie, 2017-04-28 00:08:20]

zijiehe@chromium.org changed reviewers:
+ joedow@chromium.org, sergeyu@chromium.org

[Sergey Ulanov, 2017-04-28 00:31:03]

lgtm

[Hzj_jie, 2017-04-28 01:36:23]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:38:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:51:34]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Hzj_jie, 2017-04-28 02:01:21]

zijiehe@chromium.org changed reviewers:
+ dcheng@chromium.org

[Hzj_jie, 2017-04-28 02:02:28]

Add Daniel for chromoting_messages.h.

[dcheng, 2017-04-28 02:48:46]

ipc lgtm but

1) what does capturer_id represent?
2) is there any documentation about the different processes involved in
chromoting / which processes are privileged?

[Hzj_jie, 2017-04-28 03:07:37]

On 2017/04/28 02:48:46, dcheng (OOO through May 2) wrote:
> ipc lgtm but
> 
> 1) what does capturer_id represent?
> 2) is there any documentation about the different processes involved in
> chromoting / which processes are privileged?

1) capturer_id is a field to identify the generator of a frame:
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/desktop_captu....
The background is, we have two capturer implementations for Windows, (GDI v.s.
DirectX). DirectX cannot work on all hardware, and may randomly fail because of
the limitation of its underlying hardware dependent APIs. So we need to analyze
the failure / fallback ratio.

2) We have three or four processes according to the scenarios. Desktop process,
Network process, Daemon process and RdpDesktopSession process. The former three
are required, the forth only exists in curtain mode. Desktop process captures
the screen by executing WebRTC/DesktopCapture component, it sends the capture
result to Network process through IPC chromoting_messages. Network process talks
with client directly. So we need to forward capturer_id form Desktop process to
Network process.

[Hzj_jie, 2017-04-28 03:54:30]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:55:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 05:29:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493351670768630, "parent_rev":
"7ed243fc89fb72230c47f59742128add62ae1d83", "commit_rev":
"a1336afb916a5ea783cf76454f8804ac12709624"}

[commit-bot: I haz the power, 2017-04-28 05:29:39]

Description was changed from

==========
Forward capturer id from desktop process to network process

Updates of message, proxy and agent are needed to forward capturer id to the
network process and eventually to the client.

BUG=chromium:679523, chromium:650926
==========

to

==========
Forward capturer id from desktop process to network process

Updates of message, proxy and agent are needed to forward capturer id to the
network process and eventually to the client.

BUG=chromium:679523, chromium:650926

Review-Url: https://codereview.chromium.org/2848753002
Cr-Commit-Position: refs/heads/master@{#467902}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1336afb916a5ea783cf76454f88...
==========

[commit-bot: I haz the power, 2017-04-28 05:29:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a1336afb916a5ea783cf76454f88...