Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2848723004: Fix an issue that notification is not posted if download is interrupted on start (Closed)

Created:
3 years, 7 months ago by qinmin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that notification is not posted if download is interrupted on start If a download is interrupted on start, notification is not posted. However, the download will show up in download home. This CL fixes the issue by allowing interrupted downloads to post new notifications. BUG=714798 Review-Url: https://codereview.chromium.org/2848723004 Cr-Commit-Position: refs/heads/master@{#468355} Committed: https://chromium.googlesource.com/chromium/src/+/81fb77eba496961aec989cc4945b3cf47f78fbf7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -34 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 5 chunks +28 lines, -24 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/download/download_ui_controller.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qinmin
3 years, 7 months ago (2017-04-28 19:56:27 UTC) #2
qinmin
PTAL
3 years, 7 months ago (2017-04-28 19:56:36 UTC) #3
David Trainor- moved to gerrit
lgtm
3 years, 7 months ago (2017-05-01 17:14:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848723004/1
3 years, 7 months ago (2017-05-01 17:17:34 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 18:10:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/81fb77eba496961aec989cc4945b...

Powered by Google App Engine
This is Rietveld 408576698