Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2848723003: Remove support for canvas element in tough_video_cases. (Closed)

Created:
3 years, 7 months ago by CalebRouleau
Modified:
3 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for canvas element in tough_video_cases. The canvas element simply mirrors the video element by grabbing frames from it. Removing these 3 pages should reduce benchmark_duration for tough_video_cases by ~17%. BUG=710253 Review-Url: https://codereview.chromium.org/2848723003 Cr-Commit-Position: refs/heads/master@{#467880} Committed: https://chromium.googlesource.com/chromium/src/+/4d623449fa0d8e402dea243355a411b7cdcffc5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -58 lines) Patch
M tools/perf/page_sets/tough_video_cases.py View 3 chunks +2 lines, -45 lines 0 comments Download
M tools/perf/page_sets/tough_video_cases/video.html View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nednguyen
lgtm
3 years, 7 months ago (2017-04-28 00:03:24 UTC) #3
CalebRouleau
PTAL
3 years, 7 months ago (2017-04-28 00:11:09 UTC) #4
DaleCurtis
lgtm these should be covered by gpu bots these days.
3 years, 7 months ago (2017-04-28 00:12:54 UTC) #5
johnchen
lgtm
3 years, 7 months ago (2017-04-28 00:13:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848723003/1
3 years, 7 months ago (2017-04-28 02:25:12 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 03:54:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4d623449fa0d8e402dea243355a4...

Powered by Google App Engine
This is Rietveld 408576698