Use a weak pointer when binding GuestViewBase::DidAttach.

Use a weak pointer when binding GuestViewBase::DidAttach.

The lifetime of GuestViewBase doesn't match the lifetime of GuestViewMessageFilter, so it's possible that the GuestViewBase is already destroyed by the time this callback is called.

BUG=716223
Review-Url: https://codereview.chromium.org/2848723002
Cr-Commit-Position: refs/heads/master@{#468072}
Committed: https://chromium.googlesource.com/chromium/src/+/14efbd4e93447f07f72c3978aed2ef9b0a0464d1

[lfg, 2017-04-27 22:28:19]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 22:29:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:12:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 02:12:43]

Dry run: This issue passed the CQ dry run.

[lfg, 2017-04-28 16:10:26]

Description was changed from

==========
WIP
==========

to

==========
Use a weak pointer when binding GuestViewBase::DidAttach.

The lifetime of GuestViewBase doesn't match the lifetime of
GuestViewMessageFilter, so it's possible that the GuestViewBase is already
destroyed by the time this callback is called.

BUG=716223
==========

[lfg, 2017-04-28 16:10:40]

lfg@chromium.org changed reviewers:
+ wjmaclean@chromium.org

[lfg, 2017-04-28 16:10:41]

James, can you take a look?

[wjmaclean, 2017-04-28 17:56:46]

On 2017/04/28 16:10:41, lfg wrote:
> James, can you take a look?

lgtm

[lfg, 2017-04-28 18:21:46]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2017-04-28 18:22:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 18:41:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493403706169280, "parent_rev":
"f97da42cc4b51bc03f6d1fdf1a3f4ce86d97d096", "commit_rev":
"14efbd4e93447f07f72c3978aed2ef9b0a0464d1"}

[commit-bot: I haz the power, 2017-04-28 18:41:59]

Description was changed from

==========
Use a weak pointer when binding GuestViewBase::DidAttach.

The lifetime of GuestViewBase doesn't match the lifetime of
GuestViewMessageFilter, so it's possible that the GuestViewBase is already
destroyed by the time this callback is called.

BUG=716223
==========

to

==========
Use a weak pointer when binding GuestViewBase::DidAttach.

The lifetime of GuestViewBase doesn't match the lifetime of
GuestViewMessageFilter, so it's possible that the GuestViewBase is already
destroyed by the time this callback is called.

BUG=716223

Review-Url: https://codereview.chromium.org/2848723002
Cr-Commit-Position: refs/heads/master@{#468072}
Committed:
https://chromium.googlesource.com/chromium/src/+/14efbd4e93447f07f72c3978aed2...
==========

[commit-bot: I haz the power, 2017-04-28 18:42:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14efbd4e93447f07f72c3978aed2...