[ObjC ARC] Converts ios/chrome/browser/signin:signin to ARC.

[ObjC ARC] Converts ios/chrome/browser/signin:signin to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2848673003
Cr-Commit-Position: refs/heads/master@{#483341}
Committed: https://chromium.googlesource.com/chromium/src/+/5637eff43f718e4479c6b107ff7f3628b72b0984

[stkhapugin, 2017-04-28 13:53:51]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 13:54:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 15:54:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 15:54:56]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[stkhapugin, 2017-06-15 17:12:07]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 17:12:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 18:57:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 18:57:51]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-06-20 14:47:34]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 14:47:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 16:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 16:33:05]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-06-23 09:46:21]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 09:46:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 11:03:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 11:03:34]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-06-23 12:16:51]

stkhapugin@chromium.org changed reviewers:
+ msarda@chromium.org

[stkhapugin, 2017-06-23 12:16:52]

PTAL

[msarda, 2017-06-26 11:44:47]

https://codereview.chromium.org/2848673003/diff/1/ios/chrome/browser/signin/a...
File ios/chrome/browser/signin/authentication_service.mm (right):

https://codereview.chromium.org/2848673003/diff/1/ios/chrome/browser/signin/a...
ios/chrome/browser/signin/authentication_service.mm:497: .reset(user_info);
It is not clear to me if we need to retain here - this is a map of std:string to
scoped_nsobject. Will the scoped_nsobject increase the retain count correctly in
this case?

[stkhapugin, 2017-06-26 13:06:41]

https://codereview.chromium.org/2848673003/diff/1/ios/chrome/browser/signin/a...
File ios/chrome/browser/signin/authentication_service.mm (right):

https://codereview.chromium.org/2848673003/diff/1/ios/chrome/browser/signin/a...
ios/chrome/browser/signin/authentication_service.mm:497: .reset(user_info);
On 2017/06/26 11:44:47, msarda wrote:
> It is not clear to me if we need to retain here - this is a map of std:string
to
> scoped_nsobject. Will the scoped_nsobject increase the retain count correctly
in
> this case?

Yes, scoped_nsobject increase the retain count. If you look at
scoped_nsobject.h, it has basically two implementations for reset() - one for
ARC, one for non-ARC - where the ARC one increases retain count internally,
while the non-ARC one expects a previously-retained object. That's because
explicit calls to -retain are not allowed under ARC. :)

[msarda, 2017-06-28 12:09:24]

lgtm

[stkhapugin, 2017-06-29 11:33:01]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-06-29 11:33:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 13:05:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498735981673470, "parent_rev":
"3691cc167a224f40ff2909dcf51193b93b244c0d", "commit_rev":
"d6501e13cb0bb2b57fe3426a484f36724922e6f1"}

[commit-bot: I haz the power, 2017-06-29 13:05:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498735981673470, "parent_rev":
"2e81db2a6fff00382a13aaf7c15f9ed3a870b271", "commit_rev":
"5637eff43f718e4479c6b107ff7f3628b72b0984"}

[commit-bot: I haz the power, 2017-06-29 13:05:55]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/signin:signin to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/signin:signin to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2848673003
Cr-Commit-Position: refs/heads/master@{#483341}
Committed:
https://chromium.googlesource.com/chromium/src/+/5637eff43f718e4479c6b107ff7f...
==========

[commit-bot: I haz the power, 2017-06-29 13:05:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5637eff43f718e4479c6b107ff7f...