Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 2848643002: Revert of gpu: Completely remove GpuProcessHostUIShim. (Closed)

Created:
3 years, 7 months ago by kcwu
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ozone-reviews_chromium.org, jam, darin-cc_chromium.org, kalyank, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: Completely remove GpuProcessHostUIShim. (patchset #4 id:60001 of https://codereview.chromium.org/2820463002/ ) Reason for revert: This CL break video_VideoDecodeAccelerator and video_VDASanity on all ChromeOS boards. BUG=715957 Original issue's description: > gpu: Completely remove GpuProcessHostUIShim. > > The only remaining purpose of GpuProcessHostUIShim was to send messages > back and forth between GpuProcessHost and the ozone platform. Move that > relevant code into GpuProcessHost, and remove the ui shim. > > For ozone: Remove GpuPlatformSupportHost::OnChannelEstablished(). It is > currently needed only for the drm implementation, and is essentially just > a thread hop from the IO thread to the UI thread. So do that from inside > the drm implementation, instead of having a public API and requiring the > gpu host do the thread-hop. > > BUG=709332, 711333 > > Review-Url: https://codereview.chromium.org/2820463002 > Cr-Commit-Position: refs/heads/master@{#466351} > Committed: https://chromium.googlesource.com/chromium/src/+/63c1e2603b28e1fb6a2ca120e793497ed3b37220 TBR=jbauman@chromium.org,dnicoara@chromium.org,rjkroege@chromium.org,jam@chromium.org,sadrul@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=709332, 711333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -89 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 9 chunks +25 lines, -54 lines 0 comments Download
A content/browser/gpu/gpu_process_host_ui_shim.h View 1 chunk +73 lines, -0 lines 0 comments Download
A content/browser/gpu/gpu_process_host_ui_shim.cc View 1 chunk +143 lines, -0 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h View 4 chunks +2 lines, -7 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc View 3 chunks +17 lines, -24 lines 0 comments Download
M ui/ozone/public/gpu_platform_support_host.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/ozone/public/gpu_platform_support_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/public/ozone_gpu_test_helper.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
kcwu
Created Revert of gpu: Completely remove GpuProcessHostUIShim.
3 years, 7 months ago (2017-04-27 15:10:42 UTC) #2
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 15:11:09 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698