gpu: Completely remove GpuProcessHostUIShim.

gpu: Completely remove GpuProcessHostUIShim.

The only remaining purpose of GpuProcessHostUIShim was to send messages
back and forth between GpuProcessHost and the ozone platform. Move that
relevant code into GpuProcessHost, and remove the ui shim.

For ozone: Remove GpuPlatformSupportHost::OnChannelEstablished(). It is
currently needed only for the drm implementation, and is essentially just
a thread hop from the IO thread to the UI thread. So do that from inside
the drm implementation, instead of having a public API and requiring the
gpu host do the thread-hop.

BUG=709332, 711333
Review-Url: https://codereview.chromium.org/2820463002
Cr-Commit-Position: refs/heads/master@{#466351}
Committed: https://chromium.googlesource.com/chromium/src/+/63c1e2603b28e1fb6a2ca120e793497ed3b37220

[sadrul, 2017-04-13 06:01:52]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 06:02:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 06:25:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 06:25:01]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sadrul, 2017-04-13 06:41:23]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 06:41:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 07:58:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 07:58:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-04-13 13:39:46]

Description was changed from

==========
gpu: Completely remove GpuProcessHostUIShim.

...

BUG=...
==========

to

==========
gpu: Completely remove GpuProcessHostUIShim.

The only remaining purpose of GpuProcessHostUIShim was to send messages
back and forth between GpuProcessHost and the ozone platform. Move that
relevant code into GpuProcessHost, and remove the ui shim.

For ozone: Remove GpuPlatformSupportHost::OnChannelEstablished(). It is
currently needed only for the drm implementation, and is essentially just a
thread hop from the IO thread to the UI thread. So do that from inside the
drm implementation, instead of having a public API and requiring the gpu
host do the thread-hop.

BUG=709332
==========

[sadrul, 2017-04-13 13:44:04]

sadrul@chromium.org changed reviewers:
+ dnicoara@chromium.org, jbauman@chromium.org, rjkroege@chromium.org

[sadrul, 2017-04-13 13:44:05]

jbauman@ for content changes.

dnicoara@/rjkroege@ for ozone changes.

Thanks!

[sadrul, 2017-04-13 16:34:34]

Description was changed from

==========
gpu: Completely remove GpuProcessHostUIShim.

The only remaining purpose of GpuProcessHostUIShim was to send messages
back and forth between GpuProcessHost and the ozone platform. Move that
relevant code into GpuProcessHost, and remove the ui shim.

For ozone: Remove GpuPlatformSupportHost::OnChannelEstablished(). It is
currently needed only for the drm implementation, and is essentially just a
thread hop from the IO thread to the UI thread. So do that from inside the
drm implementation, instead of having a public API and requiring the gpu
host do the thread-hop.

BUG=709332
==========

to

==========
gpu: Completely remove GpuProcessHostUIShim.

The only remaining purpose of GpuProcessHostUIShim was to send messages
back and forth between GpuProcessHost and the ozone platform. Move that
relevant code into GpuProcessHost, and remove the ui shim.

For ozone: Remove GpuPlatformSupportHost::OnChannelEstablished(). It is
currently needed only for the drm implementation, and is essentially just
a thread hop from the IO thread to the UI thread. So do that from inside
the drm implementation, instead of having a public API and requiring the
gpu host do the thread-hop.

BUG=709332, 711333
==========

[jbauman, 2017-04-15 00:56:41]

lgtm

[rjkroege, 2017-04-18 20:29:51]

https://codereview.chromium.org/2820463002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc (right):

https://codereview.chromium.org/2820463002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc:183:
cursor_->SetDrmCursorProxy(new CursorIPC(send_runner_, send_callback_));
doesn't this imply that cursor messages will go wrong if they arrive before the
gpu process has finished launching?  seems possible to me.

[sadrul, 2017-04-18 20:51:44]

https://codereview.chromium.org/2820463002/diff/20001/ui/ozone/platform/drm/h...
File ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc (right):

https://codereview.chromium.org/2820463002/diff/20001/ui/ozone/platform/drm/h...
ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc:183:
cursor_->SetDrmCursorProxy(new CursorIPC(send_runner_, send_callback_));
On 2017/04/18 20:29:51, rjkroege wrote:
> doesn't this imply that cursor messages will go wrong if they arrive before
the
> gpu process has finished launching?  seems possible to me.

Note that this can already happen without this change. This change makes sure
that OnChannelEstablished() always gets called after OnGpuProcessLaunched(),
whereas without this change, there is a race between the two.

[sadrul, 2017-04-19 16:54:07]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 16:54:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-04-19 17:25:03]

Fixed the crash on device (the change was to explicitly notify the
GpuPlatformSupportHost when the main-thread becomes available). PTAL

[sadrul, 2017-04-19 17:25:21]

sadrul@chromium.org changed reviewers:
+ jam@chromium.org

[sadrul, 2017-04-19 17:25:22]

+jam@ for browser_main_loop.cc change.

[commit-bot: I haz the power, 2017-04-19 18:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 18:02:51]

Dry run: This issue passed the CQ dry run.

[jam, 2017-04-20 00:22:20]

https://codereview.chromium.org/2820463002/diff/40001/content/browser/browser...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2820463002/diff/40001/content/browser/browser...
content/browser/browser_main_loop.cc:659: ->BindToCurrentThread();
why not just pass in the UI thread's task runner in OnGpuProcessLaunched, and
then you don't need to add more code to this file?

[sadrul, 2017-04-20 02:35:50]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 02:36:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-04-20 03:10:31]

https://codereview.chromium.org/2820463002/diff/40001/content/browser/browser...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2820463002/diff/40001/content/browser/browser...
content/browser/browser_main_loop.cc:659: ->BindToCurrentThread();
On 2017/04/20 00:22:20, jam wrote:
> why not just pass in the UI thread's task runner in OnGpuProcessLaunched, and
> then you don't need to add more code to this file?

Yep, that also works. Done.

[commit-bot: I haz the power, 2017-04-20 04:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 04:10:04]

Dry run: This issue passed the CQ dry run.

[jam, 2017-04-20 16:03:25]

lgtm

[sadrul, 2017-04-21 03:47:12]

rjkroege@: ping

[rjkroege, 2017-04-21 14:06:31]

lgtm

[sadrul, 2017-04-21 14:22:24]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2017-04-21 14:22:25]

The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2820463002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2017-04-21 14:22:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 16:00:59]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492784544992500,
"parent_rev": "80d0234a6c13bba1e14ca76f48d7c437fe5b020e", "commit_rev":
"63c1e2603b28e1fb6a2ca120e793497ed3b37220"}

[commit-bot: I haz the power, 2017-04-21 16:01:13]

Description was changed from

==========
gpu: Completely remove GpuProcessHostUIShim.

The only remaining purpose of GpuProcessHostUIShim was to send messages
back and forth between GpuProcessHost and the ozone platform. Move that
relevant code into GpuProcessHost, and remove the ui shim.

For ozone: Remove GpuPlatformSupportHost::OnChannelEstablished(). It is
currently needed only for the drm implementation, and is essentially just
a thread hop from the IO thread to the UI thread. So do that from inside
the drm implementation, instead of having a public API and requiring the
gpu host do the thread-hop.

BUG=709332, 711333
==========

to

==========
gpu: Completely remove GpuProcessHostUIShim.

The only remaining purpose of GpuProcessHostUIShim was to send messages
back and forth between GpuProcessHost and the ozone platform. Move that
relevant code into GpuProcessHost, and remove the ui shim.

For ozone: Remove GpuPlatformSupportHost::OnChannelEstablished(). It is
currently needed only for the drm implementation, and is essentially just
a thread hop from the IO thread to the UI thread. So do that from inside
the drm implementation, instead of having a public API and requiring the
gpu host do the thread-hop.

BUG=709332, 711333

Review-Url: https://codereview.chromium.org/2820463002
Cr-Commit-Position: refs/heads/master@{#466351}
Committed:
https://chromium.googlesource.com/chromium/src/+/63c1e2603b28e1fb6a2ca120e793...
==========

[commit-bot: I haz the power, 2017-04-21 16:01:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/63c1e2603b28e1fb6a2ca120e793...

[kcwu, 2017-04-27 15:10:41]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2848643002/ by kcwu@chromium.org.

The reason for reverting is: This CL break video_VideoDecodeAccelerator and
video_VDASanity on all ChromeOS boards.

BUG=715957.