Remove unused copies of EarlyZygoteLaunch()

Remove unused copies of EarlyZygoteLaunch()

It looks like this function got cargo-culted around during refactors.

* Remove unused copies for NaCl, utility process and PPAPI
* Inline the one used copy from RenderProcessHostImpl into BrowserMainLoop

No behavior changes.

BUG=none
TEST=bots

Review-Url: https://codereview.chromium.org/2848603003
Cr-Commit-Position: refs/heads/master@{#468015}
Committed: https://chromium.googlesource.com/chromium/src/+/37acc25307365737a6e4130a644c973cc0f59cd1

[James Cook, 2017-04-27 21:40:54]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:41:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-04-27 21:43:49]

jamescook@chromium.org changed reviewers:
+ kerrnel@chromium.org

[James Cook, 2017-04-27 21:43:50]

kerrnel, please take a look. (I'm only sending this to you because your name is
in the TODO.) I noticed these unreferenced copies while investigating
crbug.com/692227

https://codereview.chromium.org/2848603003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_process_host_impl.cc (left):

https://codereview.chromium.org/2848603003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_process_host_impl.cc:701:
DCHECK(!g_render_zygote);
Never written! :-)

[Lei Zhang, 2017-04-27 23:02:52]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2017-04-27 23:02:52]

Coincidentally, I started writing this CL about an hour ago too.

https://codereview.chromium.org/2848603003/diff/1/content/browser/browser_mai...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2848603003/diff/1/content/browser/browser_mai...
content/browser/browser_main_loop.cc:179: #if !defined(OS_ANDROID)
I was wondering about how Linux-y the Zygote code is. Does it really have to be:

if defined(OS_POSIX) && !defined(OS_ANDROID) && !defined(OS_MACOSX)

or can it just be:

if defined(OS_LINUX) ?

[Greg K, 2017-04-27 23:05:23]

On 2017/04/27 23:02:52, Lei Zhang wrote:
> Coincidentally, I started writing this CL about an hour ago too.
> 
>
https://codereview.chromium.org/2848603003/diff/1/content/browser/browser_mai...
> File content/browser/browser_main_loop.cc (right):
> 
>
https://codereview.chromium.org/2848603003/diff/1/content/browser/browser_mai...
> content/browser/browser_main_loop.cc:179: #if !defined(OS_ANDROID)
> I was wondering about how Linux-y the Zygote code is. Does it really have to
be:
> 
> if defined(OS_POSIX) && !defined(OS_ANDROID) && !defined(OS_MACOSX)
> 
> or can it just be:
> 
> if defined(OS_LINUX) ?

I believe that exists because mdempsky@ got the zygote working on BSD, but I
have no idea if Chrome still runs on BSD.

- Greg

[Lei Zhang, 2017-04-27 23:15:22]

On 2017/04/27 23:05:23, Greg K wrote:
> I believe that exists because mdempsky@ got the zygote working on BSD, but I
> have no idea if Chrome still runs on BSD.

OK, let's leave the ifdef as is then.

Looks a lot like what I wrote locally, so looks good.

[Greg K, 2017-04-27 23:16:10]

On 2017/04/27 23:15:22, Lei Zhang wrote:
> On 2017/04/27 23:05:23, Greg K wrote:
> > I believe that exists because mdempsky@ got the zygote working on BSD, but I
> > have no idea if Chrome still runs on BSD.
> 
> OK, let's leave the ifdef as is then.
> 
> Looks a lot like what I wrote locally, so looks good.

Same. LGTM. Thanks for doing this James!

[commit-bot: I haz the power, 2017-04-28 01:37:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:37:20]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-04-28 02:25:55]

jamescook@chromium.org changed reviewers:
+ jam@chromium.org

[James Cook, 2017-04-28 02:25:55]

jam, can I get OWNERS?

[jam, 2017-04-28 15:43:54]

lgtm

[James Cook, 2017-04-28 15:46:12]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-04-28 15:46:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 15:54:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493394372303910, "parent_rev":
"d6d85694bda0d4eb0a9ca014e0c0ab851d95fff3", "commit_rev":
"37acc25307365737a6e4130a644c973cc0f59cd1"}

[commit-bot: I haz the power, 2017-04-28 15:55:05]

Description was changed from

==========
Remove unused copies of EarlyZygoteLaunch()

It looks like this function got cargo-culted around during refactors.

* Remove unused copies for NaCl, utility process and PPAPI
* Inline the one used copy from RenderProcessHostImpl into BrowserMainLoop

No behavior changes.

BUG=none
TEST=bots
==========

to

==========
Remove unused copies of EarlyZygoteLaunch()

It looks like this function got cargo-culted around during refactors.

* Remove unused copies for NaCl, utility process and PPAPI
* Inline the one used copy from RenderProcessHostImpl into BrowserMainLoop

No behavior changes.

BUG=none
TEST=bots

Review-Url: https://codereview.chromium.org/2848603003
Cr-Commit-Position: refs/heads/master@{#468015}
Committed:
https://chromium.googlesource.com/chromium/src/+/37acc25307365737a6e4130a644c...
==========

[commit-bot: I haz the power, 2017-04-28 15:55:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37acc25307365737a6e4130a644c...