Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2848583002: [turbofan] Fix impossible type handling for TypeGuard and BooleanNot. (Closed)

Created:
3 years, 7 months ago by Jarin
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix impossible type handling for TypeGuard and BooleanNot. This also fixes incorrect type for fixed array accesses. BUG=chromium:715651, v8:6309, chromium:715204 Review-Url: https://codereview.chromium.org/2848583002 Cr-Commit-Position: refs/heads/master@{#44926} Committed: https://chromium.googlesource.com/v8/v8/+/ff2109d53efccb2642df26ae2156f56285822885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -7 lines) Patch
M src/compiler/access-builder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +13 lines, -4 lines 0 comments Download
A test/mjsunit/compiler/regress-715204.js View 1 chunk +13 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-715651.js View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jarin
Could you take a look, please?
3 years, 7 months ago (2017-04-27 10:51:10 UTC) #4
Benedikt Meurer
lgtm
3 years, 7 months ago (2017-04-27 11:06:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848583002/1
3 years, 7 months ago (2017-04-27 11:33:38 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 11:35:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ff2109d53efccb2642df26ae2156f562858...

Powered by Google App Engine
This is Rietveld 408576698