Revert of binding: Changes the association among global-proxy/global/window-instance (2nd attempt).…

Revert of binding: Changes the association among global-proxy/global/window-instance (2nd attempt). (patchset #7 id:120001 of https://codereview.chromium.org/2693893007/ )

Reason for revert:
The change should be causing crash issues.
https://crbug.com/712638
https://crbug.com/713676
https://crbug.com/713667
https://crbug.com/715150
The root cause could be different but the CL should have at least triggered the crashes.

Original issue's description:
> binding: Changes the association among global-proxy/global/window-instance (2nd attempt).
>
> The first attempt is: https://crrev.com/2617733004
>
> Since V8 now supports internal fields for the global proxies,
> let's change the mappings among global proxy / global object /
> C++ instance in Blink.
>
> With this CL, the global proxy and C++ instance point to each
> other, and a global object points to the C++ instance (without
> reverse pointer).
>
> Note that this CL makes one big difference.  For non-window objects,
> Blink objects always live longer than V8 wrappers.  This CL
> introduces an exception; DOMWindow may be collected before the V8
> wrapper object gets collected because the V8 wrapper is the global
> proxy which remains the same while navigations.
>
> BUG=675872
> Review-Url: https://codereview.chromium.org/2693893007
> Cr-Commit-Position: refs/heads/master@{#465197}
> Committed: https://chromium.googlesource.com/chromium/src/+/ae0d679c61a85bc16722724a4a96e30a1dee9dd2

This CL reverts the following CL, too.
v8binding: Makes ToV8(window) work without a frame.
https://codereview.chromium.org/2713623002/

Original issue's description:
> v8binding: Makes ToV8(window) work without a frame.
>
> Makes DOMWindow hold a WindowProxyManager and makes
> it possible that ToV8(window) work without a frame.
>
> With this CL, all tests in
> external/wpt/html/webappapis/scripting/events/compile-event-handler-settings-objects.html
> pass without a failure.
>
> This CL is a preparation for
> https://crrev.com/2693893007
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2713623002
> Cr-Commit-Position: refs/heads/master@{#464907}
> Committed: https://chromium.googlesource.com/chromium/src/+/58af3664facba6332528fd983988d51cf3636af4

BUG=712638, 713676, 713667, 715150
Review-Url: https://codereview.chromium.org/2848503002
Cr-Commit-Position: refs/heads/master@{#467623}
Committed: https://chromium.googlesource.com/chromium/src/+/4a97922bec93566369465c2e3d7facc45d165005

[Yuki, 2017-04-27 04:33:50]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 04:34:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 05:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 05:41:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yuki, 2017-04-27 06:30:22]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 06:30:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2017-04-27 08:26:07]

Description was changed from

==========
Revert of binding: Changes the association among
global-proxy/global/window-instance (2nd attempt). (patchset #7 id:120001 of
https://codereview.chromium.org/2693893007/ )

Reason for revert:
The change should be causing crash issues.
https://crbug.com/712638
https://crbug.com/713676
https://crbug.com/713667
https://crbug.com/715150
The root cause could be different but the CL should have at least triggered the
crashes.

Original issue's description:
> binding: Changes the association among global-proxy/global/window-instance
(2nd attempt).
>
> The first attempt is: https://crrev.com/2617733004
>
> Since V8 now supports internal fields for the global proxies,
> let's change the mappings among global proxy / global object /
> C++ instance in Blink.
>
> With this CL, the global proxy and C++ instance point to each
> other, and a global object points to the C++ instance (without
> reverse pointer).
>
> Note that this CL makes one big difference.  For non-window objects,
> Blink objects always live longer than V8 wrappers.  This CL
> introduces an exception; DOMWindow may be collected before the V8
> wrapper object gets collected because the V8 wrapper is the global
> proxy which remains the same while navigations.
>
> BUG=675872
> Review-Url: https://codereview.chromium.org/2693893007
> Cr-Commit-Position: refs/heads/master@{#465197}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ae0d679c61a85bc16722724a4a96...

BUG=712638,713676,713667,715150
==========

to

==========
Revert of binding: Changes the association among
global-proxy/global/window-instance (2nd attempt). (patchset #7 id:120001 of
https://codereview.chromium.org/2693893007/ )

Reason for revert:
The change should be causing crash issues.
https://crbug.com/712638
https://crbug.com/713676
https://crbug.com/713667
https://crbug.com/715150
The root cause could be different but the CL should have at least triggered the
crashes.

Original issue's description:
> binding: Changes the association among global-proxy/global/window-instance
(2nd attempt).
>
> The first attempt is: https://crrev.com/2617733004
>
> Since V8 now supports internal fields for the global proxies,
> let's change the mappings among global proxy / global object /
> C++ instance in Blink.
>
> With this CL, the global proxy and C++ instance point to each
> other, and a global object points to the C++ instance (without
> reverse pointer).
>
> Note that this CL makes one big difference.  For non-window objects,
> Blink objects always live longer than V8 wrappers.  This CL
> introduces an exception; DOMWindow may be collected before the V8
> wrapper object gets collected because the V8 wrapper is the global
> proxy which remains the same while navigations.
>
> BUG=675872
> Review-Url: https://codereview.chromium.org/2693893007
> Cr-Commit-Position: refs/heads/master@{#465197}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ae0d679c61a85bc16722724a4a96...

This CL reverts the following CL, too.
v8binding: Makes ToV8(window) work without a frame.
https://codereview.chromium.org/2713623002/

Original issue's description:
> v8binding: Makes ToV8(window) work without a frame.
>
> Makes DOMWindow hold a WindowProxyManager and makes
> it possible that ToV8(window) work without a frame.
>
> With this CL, all tests in
>
external/wpt/html/webappapis/scripting/events/compile-event-handler-settings-objects.html
> pass without a failure.
>
> This CL is a preparation for
> https://crrev.com/2693893007
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2713623002
> Cr-Commit-Position: refs/heads/master@{#464907}
> Committed:
https://chromium.googlesource.com/chromium/src/+/58af3664facba6332528fd983988...

BUG=712638,713676,713667,715150
==========

[Yuki, 2017-04-27 08:27:14]

yukishiino@chromium.org changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org, mlippautz@chromium.org

[Yuki, 2017-04-27 08:27:15]

Could you review this CL?

[haraken, 2017-04-27 08:31:36]

LGTM

[commit-bot: I haz the power, 2017-04-27 08:51:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 08:51:21]

Dry run: This issue passed the CQ dry run.

[Yuki, 2017-04-27 08:56:19]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2017-04-27 08:56:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Lippautz, 2017-04-27 08:56:42]

LGTM

Thanks a lot! If that fixes the crashers we should really deeply understand what
is going on here before relanding.

[Yuki, 2017-04-27 08:59:56]

On 2017/04/27 08:56:42, Michael Lippautz wrote:
> LGTM
> 
> Thanks a lot! If that fixes the crashers we should really deeply understand
what
> is going on here before relanding.

Agreed.  Also I think that we can land the change splitted into more small
pieces, so that it's easy to tell what part of the change would cause the
crashes.

[commit-bot: I haz the power, 2017-04-27 09:01:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493283379255360,
"parent_rev": "659c8284c33baf483121f1248d5aaa989d5dabe0", "commit_rev":
"4a97922bec93566369465c2e3d7facc45d165005"}

[commit-bot: I haz the power, 2017-04-27 09:01:31]

Description was changed from

==========
Revert of binding: Changes the association among
global-proxy/global/window-instance (2nd attempt). (patchset #7 id:120001 of
https://codereview.chromium.org/2693893007/ )

Reason for revert:
The change should be causing crash issues.
https://crbug.com/712638
https://crbug.com/713676
https://crbug.com/713667
https://crbug.com/715150
The root cause could be different but the CL should have at least triggered the
crashes.

Original issue's description:
> binding: Changes the association among global-proxy/global/window-instance
(2nd attempt).
>
> The first attempt is: https://crrev.com/2617733004
>
> Since V8 now supports internal fields for the global proxies,
> let's change the mappings among global proxy / global object /
> C++ instance in Blink.
>
> With this CL, the global proxy and C++ instance point to each
> other, and a global object points to the C++ instance (without
> reverse pointer).
>
> Note that this CL makes one big difference.  For non-window objects,
> Blink objects always live longer than V8 wrappers.  This CL
> introduces an exception; DOMWindow may be collected before the V8
> wrapper object gets collected because the V8 wrapper is the global
> proxy which remains the same while navigations.
>
> BUG=675872
> Review-Url: https://codereview.chromium.org/2693893007
> Cr-Commit-Position: refs/heads/master@{#465197}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ae0d679c61a85bc16722724a4a96...

This CL reverts the following CL, too.
v8binding: Makes ToV8(window) work without a frame.
https://codereview.chromium.org/2713623002/

Original issue's description:
> v8binding: Makes ToV8(window) work without a frame.
>
> Makes DOMWindow hold a WindowProxyManager and makes
> it possible that ToV8(window) work without a frame.
>
> With this CL, all tests in
>
external/wpt/html/webappapis/scripting/events/compile-event-handler-settings-objects.html
> pass without a failure.
>
> This CL is a preparation for
> https://crrev.com/2693893007
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2713623002
> Cr-Commit-Position: refs/heads/master@{#464907}
> Committed:
https://chromium.googlesource.com/chromium/src/+/58af3664facba6332528fd983988...

BUG=712638,713676,713667,715150
==========

to

==========
Revert of binding: Changes the association among
global-proxy/global/window-instance (2nd attempt). (patchset #7 id:120001 of
https://codereview.chromium.org/2693893007/ )

Reason for revert:
The change should be causing crash issues.
https://crbug.com/712638
https://crbug.com/713676
https://crbug.com/713667
https://crbug.com/715150
The root cause could be different but the CL should have at least triggered the
crashes.

Original issue's description:
> binding: Changes the association among global-proxy/global/window-instance
(2nd attempt).
>
> The first attempt is: https://crrev.com/2617733004
>
> Since V8 now supports internal fields for the global proxies,
> let's change the mappings among global proxy / global object /
> C++ instance in Blink.
>
> With this CL, the global proxy and C++ instance point to each
> other, and a global object points to the C++ instance (without
> reverse pointer).
>
> Note that this CL makes one big difference.  For non-window objects,
> Blink objects always live longer than V8 wrappers.  This CL
> introduces an exception; DOMWindow may be collected before the V8
> wrapper object gets collected because the V8 wrapper is the global
> proxy which remains the same while navigations.
>
> BUG=675872
> Review-Url: https://codereview.chromium.org/2693893007
> Cr-Commit-Position: refs/heads/master@{#465197}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ae0d679c61a85bc16722724a4a96...

This CL reverts the following CL, too.
v8binding: Makes ToV8(window) work without a frame.
https://codereview.chromium.org/2713623002/

Original issue's description:
> v8binding: Makes ToV8(window) work without a frame.
>
> Makes DOMWindow hold a WindowProxyManager and makes
> it possible that ToV8(window) work without a frame.
>
> With this CL, all tests in
>
external/wpt/html/webappapis/scripting/events/compile-event-handler-settings-objects.html
> pass without a failure.
>
> This CL is a preparation for
> https://crrev.com/2693893007
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2713623002
> Cr-Commit-Position: refs/heads/master@{#464907}
> Committed:
https://chromium.googlesource.com/chromium/src/+/58af3664facba6332528fd983988...

BUG=712638,713676,713667,715150

Review-Url: https://codereview.chromium.org/2848503002
Cr-Commit-Position: refs/heads/master@{#467623}
Committed:
https://chromium.googlesource.com/chromium/src/+/4a97922bec93566369465c2e3d7f...
==========

[commit-bot: I haz the power, 2017-04-27 09:01:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4a97922bec93566369465c2e3d7f...

[Yuki, 2017-04-27 09:02:37]

Oops, I forgot to write a note.

Note that this revert CL was created manually because it's hard to revert
mechanically due to several dependencies.  But this CL reverts the two CLs of
mine.