Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2848493004: Avoiding voice search crash if none of search providers returned anything. (Closed)

Created:
3 years, 7 months ago by vadimt
Modified:
3 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoiding voice search crash if none of search providers returned anything. It's highly unlikely that this can happen, but just in case. The voice search popup will keep staying with no other way to dismiss it except reopening the launcher, but I don't think we should take too much care of this edge case beyond simply not breaking. Bug=712331 Review-Url: https://codereview.chromium.org/2848493004 Cr-Commit-Position: refs/heads/master@{#468068} Committed: https://chromium.googlesource.com/chromium/src/+/dd27914ea0a7b83ca881bc9384c713a58f11a0a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/app_list/views/search_result_list_view.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
vadimt
3 years, 7 months ago (2017-04-28 01:40:09 UTC) #2
xiyuan
lgtm
3 years, 7 months ago (2017-04-28 16:00:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848493004/1
3 years, 7 months ago (2017-04-28 17:50:06 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 18:31:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dd27914ea0a7b83ca881bc9384c7...

Powered by Google App Engine
This is Rietveld 408576698