Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2848493003: remove TokenType.KEYWORD (Closed)

Created:
3 years, 7 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
Paul Berry, ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

remove TokenType.KEYWORD Breaking change to be landed after all existing callsites have been converted to use the new API. This is part 2 of https://codereview.chromium.org/2842643004/ * make Keyword extend TokenType * make TokenType.AS be the same object as Keyword.AS * make TokenType.IS be the same object as Keyword.IS * remove TokenType.KEYWORD * remove unnecessary Keyword.info method R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/e0e892008a9ba42135765e5597b3a595039aea97

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -96 lines) Patch
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 3 chunks +3 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 7 chunks +86 lines, -85 lines 0 comments Download
M pkg/front_end/test/precedence_info_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/test/token_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
danrubel
3 years, 7 months ago (2017-04-27 21:46:43 UTC) #3
Paul Berry
Seems reasonable. I don't want to approve it until callsites have been updated, though :)
3 years, 7 months ago (2017-04-28 16:57:45 UTC) #5
Paul Berry
lgtm
3 years, 7 months ago (2017-05-08 13:09:22 UTC) #6
danrubel
Committed patchset #2 (id:20001) manually as e0e892008a9ba42135765e5597b3a595039aea97 (presubmit successful).
3 years, 7 months ago (2017-05-08 15:20:30 UTC) #8
ahe
3 years, 6 months ago (2017-05-31 13:31:55 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698