Feature Policy: Only add container policy once

Feature Policy: Only add container policy once

A poorly-positioned closing parenthesis meant that the container policy
was being applied to newly-created policy objects once per supported
feature. (Adding the container policy is idempotent, so this doesn't
represent anything other than an inefficiency at policy creation time.)

Review-Url: https://codereview.chromium.org/2848443005
Cr-Commit-Position: refs/heads/master@{#477191}
Committed: https://chromium.googlesource.com/chromium/src/+/07fadbc84d1cfaac39addc39c2a64b4eafa89030

[iclelland, 2017-04-28 03:34:15]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 03:35:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 04:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 04:53:31]

Dry run: This issue passed the CQ dry run.

[iclelland, 2017-04-28 15:15:42]

iclelland@chromium.org changed reviewers:
+ raymes@chromium.org

[iclelland, 2017-04-28 15:15:43]

+r raymes, can you take a look?

[raymes, 2017-04-30 23:44:06]

lgtm

I wonder if we should set a bool in AddContainerPolicy to DCHECK that it only
happens once?

[iclelland, 2017-06-05 19:28:32]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 19:29:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iclelland, 2017-06-05 20:05:13]

On 2017/04/30 23:44:06, raymes wrote:
> lgtm
> 
> I wonder if we should set a bool in AddContainerPolicy to DCHECK that it only
> happens once?

That seems like overkill -- it would have to be a member var, wrapped in "#if
!defined(NDEBUG)||defined(DCHECK_ALWAYS_ON)", reset in the constructor, and set
in AddContainerPolicy, I think. If AddContainerPolicy were a public method, then
I'd agree, but it's private, and it's straightforward to check the one source
file to see that it can only be called in one place.

If you feel more strongly about it, then I'd prefer to just inline it into
CreateFromParentPolicy to be sure.

[commit-bot: I haz the power, 2017-06-05 23:45:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 23:45:06]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[raymes, 2017-06-06 01:45:13]

still lgtm

[iclelland, 2017-06-06 03:20:20]

The CQ bit was checked by iclelland@chromium.org

[commit-bot: I haz the power, 2017-06-06 03:20:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 04:12:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496719220066870,
"parent_rev": "19d7d854deaeb76f9855ae10a0a8a4718c645755", "commit_rev":
"07fadbc84d1cfaac39addc39c2a64b4eafa89030"}

[commit-bot: I haz the power, 2017-06-06 04:12:14]

Description was changed from

==========
Feature Policy: Only add container policy once

A poorly-positioned closing parenthesis meant that the container policy
was being applied to newly-created policy objects once per supported
feature. (Adding the container policy is idempotent, so this doesn't
represent anything other than an inefficiency at policy creation time.)
==========

to

==========
Feature Policy: Only add container policy once

A poorly-positioned closing parenthesis meant that the container policy
was being applied to newly-created policy objects once per supported
feature. (Adding the container policy is idempotent, so this doesn't
represent anything other than an inefficiency at policy creation time.)

Review-Url: https://codereview.chromium.org/2848443005
Cr-Commit-Position: refs/heads/master@{#477191}
Committed:
https://chromium.googlesource.com/chromium/src/+/07fadbc84d1cfaac39addc39c2a6...
==========

[commit-bot: I haz the power, 2017-06-06 04:12:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/07fadbc84d1cfaac39addc39c2a6...