Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2848443003: [recipes.py] add missing helpstrings, merge test subcommands into main parser. (Closed)

Created:
3 years, 7 months ago by iannucci
Modified:
3 years, 7 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[recipes.py] add missing helpstrings, merge test subcommands into main parser. This also has the nice benefit of allowing `test --help` to work correctly. R=dnj@chromium.org, phajdan.jr@chromium.org BUG= Review-Url: https://codereview.chromium.org/2848443003 Committed: https://github.com/luci/recipes-py/commit/088cc7b5423bcf53a6545ac3483ed2a891ae723f

Patch Set 1 #

Patch Set 2 : missing period #

Patch Set 3 : rebase #

Patch Set 4 : argument error #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : add some docs #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -167 lines) Patch
M recipe_engine/autoroll.py View 1 chunk +12 lines, -9 lines 0 comments Download
M recipe_engine/bundle.py View 2 chunks +10 lines, -9 lines 0 comments Download
M recipe_engine/depgraph.py View 1 2 3 4 5 6 7 1 chunk +19 lines, -16 lines 0 comments Download
M recipe_engine/doc.py View 1 chunk +5 lines, -3 lines 0 comments Download
M recipe_engine/fetch.py View 2 chunks +4 lines, -3 lines 0 comments Download
M recipe_engine/lint_test.py View 1 chunk +4 lines, -2 lines 0 comments Download
M recipe_engine/refs.py View 1 chunk +2 lines, -2 lines 0 comments Download
M recipe_engine/remote.py View 1 chunk +2 lines, -2 lines 0 comments Download
M recipe_engine/run.py View 1 2 3 4 5 6 7 2 chunks +39 lines, -36 lines 0 comments Download
M recipe_engine/test.py View 1 2 3 4 5 6 7 3 chunks +71 lines, -82 lines 0 comments Download
M recipes.py View 1 2 3 4 5 6 7 3 chunks +35 lines, -3 lines 0 comments Download

Messages

Total messages: 38 (34 generated)
iannucci
3 years, 7 months ago (2017-04-27 02:20:50 UTC) #1
dnj
lgtm
3 years, 7 months ago (2017-04-27 17:16:43 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848443003/140001
3 years, 7 months ago (2017-04-29 17:23:03 UTC) #35
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 17:26:18 UTC) #38
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://github.com/luci/recipes-py/commit/088cc7b5423bcf53a6545ac3483ed2a891a...

Powered by Google App Engine
This is Rietveld 408576698