MD Settings: Remove usage of deprecated iron-flex-layout.html, for CrOS.

MD Settings: Remove usage of deprecated iron-flex-layout.html, for CrOS.

BUG=635633
TEST=Open chrome:md-settings, look at the DevTools console, no more warnings.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2848443002
Cr-Commit-Position: refs/heads/master@{#468480}
Committed: https://chromium.googlesource.com/chromium/src/+/abeb3b928b8834dd180f8b75ccca53b52d6cde55

[dpapad, 2017-04-27 01:09:00]

Description was changed from

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html, for CrOS.

BUG=635633
==========

to

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html, for CrOS.

BUG=635633
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-27 22:55:22]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 22:56:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-27 22:59:57]

Description was changed from

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html, for CrOS.

BUG=635633
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html, for CrOS.

BUG=635633
TEST=Open chrome:md-settings, look at the DevTools console, no more warnings.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-28 00:56:49]

dpapad@chromium.org changed reviewers:
+ michaelpg@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:41:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:41:33]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dpapad, 2017-04-28 17:56:51]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 17:57:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 20:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 20:14:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dpapad, 2017-04-28 22:37:08]

On 2017/04/28 at 00:56:50, dpapad wrote:
> 

Need to fix failing Chrome OS tests. Will ping this thread once ready.

[dpapad, 2017-04-29 01:11:57]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 01:12:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-29 02:01:50]

Fixed CrOS test, PTAL

[commit-bot: I haz the power, 2017-04-29 02:24:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 02:24:19]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-05-01 18:37:44]

dpapad@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2017-05-01 19:07:31]

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:14:
<style include="settings-shared iron-flex iron-flex-alignment">
-alignment not needed? (center and center-justified are in iron-flex)

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html
(right):

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html:20:
overflow-y: auto;
display: flex;
flex-direction: column;

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html:56: <div
id="pairedContainer" class="container layout vertical"
Elim "layout vertical"

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html:81: <div
id="unpairedContainer" class="container layout vertical"
Elim "layout vertical"

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_subpage.html
(right):

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_subpage.html:86:
<cr-network-list id="networkList" show-buttons
Ah, this was my problem. I'd actually be more comfortable adding to CSS:

cr-network-list {
  flex: 1;
}

To mimic the previous behavior (the new 'flex' also includes a flex-basis value
that is the problem).

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_subpage.html:106:
<cr-network-list class="flex" show-buttons
I think we need to fix this one also.

https://codereview.chromium.org/2848443002/diff/80001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/network/cr_network_select.html (right):

https://codereview.chromium.org/2848443002/diff/80001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/network/cr_network_select.html:13:
<cr-network-list id="neworkList" class ="flex"
nit: just set flex=1 for #networkList

[dpapad, 2017-05-01 19:10:41]

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_subpage.html
(right):

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_subpage.html:86:
<cr-network-list id="networkList" show-buttons
On 2017/05/01 at 19:07:31, stevenjb wrote:
> Ah, this was my problem. I'd actually be more comfortable adding to CSS:
> 
> cr-network-list {
>   flex: 1;
> }
> 
> To mimic the previous behavior (the new 'flex' also includes a flex-basis
value that is the problem).

FYI
https://github.com/PolymerElements/iron-flex-layout/issues/87#issuecomment-29...

[dpapad, 2017-05-01 19:38:28]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-05-01 19:38:43]

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:14:
<style include="settings-shared iron-flex iron-flex-alignment">
On 2017/05/01 at 19:07:30, stevenjb wrote:
> -alignment not needed? (center and center-justified are in iron-flex)

There are more rules in iron-flex-alignment, which I thinhk also need to be
applied here (otherwise it is not equivalent to the previous version of the
code), see
https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro....

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html
(right):

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html:20:
overflow-y: auto;
On 2017/05/01 at 19:07:30, stevenjb wrote:
> display: flex;
> flex-direction: column;

Done.

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html:56: <div
id="pairedContainer" class="container layout vertical"
On 2017/05/01 at 19:07:30, stevenjb wrote:
> Elim "layout vertical"

Done.

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_subpage.html
(right):

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_subpage.html:86:
<cr-network-list id="networkList" show-buttons
On 2017/05/01 at 19:10:40, dpapad wrote:
> On 2017/05/01 at 19:07:31, stevenjb wrote:
> > Ah, this was my problem. I'd actually be more comfortable adding to CSS:
> > 
> > cr-network-list {
> >   flex: 1;
> > }
> > 
> > To mimic the previous behavior (the new 'flex' also includes a flex-basis
value that is the problem).
> 
> FYI
https://github.com/PolymerElements/iron-flex-layout/issues/87#issuecomment-29...

Done. Added flex:1 as requested.

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_subpage.html:106:
<cr-network-list class="flex" show-buttons
On 2017/05/01 at 19:07:31, stevenjb wrote:
> I think we need to fix this one also.

Done.

https://codereview.chromium.org/2848443002/diff/80001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/network/cr_network_select.html (right):

https://codereview.chromium.org/2848443002/diff/80001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/network/cr_network_select.html:13:
<cr-network-list id="neworkList" class ="flex"
On 2017/05/01 at 19:07:31, stevenjb wrote:
> nit: just set flex=1 for #networkList

Done. Also fixed typo.

[commit-bot: I haz the power, 2017-05-01 19:39:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2017-05-01 20:20:42]

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:14:
<style include="settings-shared iron-flex iron-flex-alignment">
On 2017/05/01 19:38:43, dpapad wrote:
> On 2017/05/01 at 19:07:30, stevenjb wrote:
> > -alignment not needed? (center and center-justified are in iron-flex)
> 
> There are more rules in iron-flex-alignment, which I thinhk also need to be
> applied here (otherwise it is not equivalent to the previous version of the
> code), see
>
https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro....

That's duplicated in iron-flex also (it looks like they included the common
cases in iron-flex, even though it is confusing):
https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro...

https://codereview.chromium.org/2848443002/diff/80001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/network/cr_network_select.html (right):

https://codereview.chromium.org/2848443002/diff/80001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/network/cr_network_select.html:13:
<cr-network-list id="neworkList" class ="flex"
On 2017/05/01 19:38:43, dpapad wrote:
> On 2017/05/01 at 19:07:31, stevenjb wrote:
> > nit: just set flex=1 for #networkList
> 
> Done. Also fixed typo.

Thanks, but you'll need to fix the JS also.

[dpapad, 2017-05-01 20:41:59]

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/2848443002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:14:
<style include="settings-shared iron-flex iron-flex-alignment">
> That's duplicated in iron-flex also (it looks like they included the common
cases in iron-flex, even though it is confusing):
>
https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro...

Done. Removed iron-flex-alignment.

https://codereview.chromium.org/2848443002/diff/80001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/network/cr_network_select.html (right):

https://codereview.chromium.org/2848443002/diff/80001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/network/cr_network_select.html:13:
<cr-network-list id="neworkList" class ="flex"
> Thanks, but you'll need to fix the JS also.

Done.

[stevenjb, 2017-05-01 20:48:43]

lgtm

[dpapad, 2017-05-01 22:03:46]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-05-01 22:05:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 23:25:03]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1493676226453890,
"parent_rev": "dd5f1e9961edb89b0df27420a76ed3fcc5703424", "commit_rev":
"abeb3b928b8834dd180f8b75ccca53b52d6cde55"}

[commit-bot: I haz the power, 2017-05-01 23:25:26]

Description was changed from

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html, for CrOS.

BUG=635633
TEST=Open chrome:md-settings, look at the DevTools console, no more warnings.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove usage of deprecated iron-flex-layout.html, for CrOS.

BUG=635633
TEST=Open chrome:md-settings, look at the DevTools console, no more warnings.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2848443002
Cr-Commit-Position: refs/heads/master@{#468480}
Committed:
https://chromium.googlesource.com/chromium/src/+/abeb3b928b8834dd180f8b75ccca...
==========

[commit-bot: I haz the power, 2017-05-01 23:25:27]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/abeb3b928b8834dd180f8b75ccca...