Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2848353003: [Devtools] Fixed resource having no content if from xhr blob (Closed)

Created:
3 years, 7 months ago by allada
Modified:
3 years, 7 months ago
Reviewers:
caseq, dgozman
CC:
halliwell, chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed resource having no content if from xhr blob Offending patch: https://codereview.chromium.org/2460573002/ In the event that a resource is an xhr request and the data had been saved to a file and had an error code in the header it was not showing any content uppon request for body. R=dgozman,caseq BUG=687677, 659789 Review-Url: https://codereview.chromium.org/2848353003 Cr-Commit-Position: refs/heads/master@{#468827} Committed: https://chromium.googlesource.com/chromium/src/+/35aaf5a9b46c7464901e6dab4c8c947cf9f60c7a

Patch Set 1 #

Total comments: 1

Patch Set 2 : [Devtools] Fixed resource having no content if from xhr blob #

Messages

Total messages: 9 (5 generated)
allada
PTL
3 years, 7 months ago (2017-05-02 02:19:48 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2848353003/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html File third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html (right): https://codereview.chromium.org/2848353003/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html#newcode302 third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html:302: * Evaluates expression in page. We don't add ...
3 years, 7 months ago (2017-05-02 19:36:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848353003/20001
3 years, 7 months ago (2017-05-02 22:33:08 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 00:07:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/35aaf5a9b46c7464901e6dab4c8c...

Powered by Google App Engine
This is Rietveld 408576698