Add WPTManifest log line to diagnose slow manifest generation

Add WPTManifest log line to diagnose slow manifest generation

BUG=714503
Review-Url: https://codereview.chromium.org/2848353002
Cr-Commit-Position: refs/heads/master@{#468884}
Committed: https://chromium.googlesource.com/chromium/src/+/a46809a3fbc319f5679b0c55102c870602119ac7

[jeffcarp, 2017-05-01 20:30:41]

The CQ bit was checked by jeffcarp@chromium.org

[jeffcarp, 2017-05-01 20:30:45]

The CQ bit was unchecked by jeffcarp@chromium.org

[jeffcarp, 2017-05-01 20:30:54]

jeffcarp@chromium.org changed reviewers:
+ tansell@chromium.org

[mithro, 2017-05-02 00:08:48]

lgtm

LGTM

Can you add a log statement to the top level run/main/etc function? (Preferable
in a try/finally so it always gets called.)

[jeffcarp, 2017-05-02 18:20:39]

On 2017/05/02 at 00:08:48, tansell wrote:
> lgtm
> 
> LGTM
> 
> Can you add a log statement to the top level run/main/etc function?
(Preferable in a try/finally so it always gets called.)

ensure_manifest is called from a few different places. Do you mean the main
function specifically for run-webkit-tests? I'll upload a patch for you to take
a look.

[jeffcarp, 2017-05-02 18:31:39]

On 2017/05/02 at 18:20:39, jeffcarp wrote:
> On 2017/05/02 at 00:08:48, tansell wrote:
> > lgtm
> > 
> > LGTM
> > 
> > Can you add a log statement to the top level run/main/etc function?
(Preferable in a try/finally so it always gets called.)
> 
> ensure_manifest is called from a few different places. Do you mean the main
function specifically for run-webkit-tests? I'll upload a patch for you to take
a look.

Ok I added a try, finally - lmk if that's what you had in mind

[mithro, 2017-05-03 02:01:17]

The CQ bit was checked by tansell@chromium.org

[mithro, 2017-05-03 02:01:17]

lgtm

Yeap, LGTM!

[commit-bot: I haz the power, 2017-05-03 02:02:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 03:39:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493776877221040,
"parent_rev": "3781bba7e714f7955f869ca1b14b810209513878", "commit_rev":
"a46809a3fbc319f5679b0c55102c870602119ac7"}

[commit-bot: I haz the power, 2017-05-03 03:39:36]

Description was changed from

==========
Add WPTManifest log line to diagnose slow manifest generation

BUG=714503
==========

to

==========
Add WPTManifest log line to diagnose slow manifest generation

BUG=714503

Review-Url: https://codereview.chromium.org/2848353002
Cr-Commit-Position: refs/heads/master@{#468884}
Committed:
https://chromium.googlesource.com/chromium/src/+/a46809a3fbc319f5679b0c55102c...
==========

[commit-bot: I haz the power, 2017-05-03 03:39:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a46809a3fbc319f5679b0c55102c...