Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2848333002: Add and update prefs for search engine promo (Closed)

Created:
3 years, 7 months ago by Yusuf
Modified:
3 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add and update prefs for search engine promo - Adds new shared pref key and values for search engine promo state - Exposes prevous promo type features in ChromeFeatureList to java BUG=712833, 712836 Review-Url: https://codereview.chromium.org/2848333002 Cr-Commit-Position: refs/heads/master@{#468458} Committed: https://chromium.googlesource.com/chromium/src/+/9e88ce2b0296bc72489bf3f78a23da8d310d29e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Yusuf
3 years, 7 months ago (2017-05-01 19:33:07 UTC) #2
gone
lgtm
3 years, 7 months ago (2017-05-01 21:48:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848333002/1
3 years, 7 months ago (2017-05-01 21:49:34 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 22:31:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e88ce2b0296bc72489bf3f78a23...

Powered by Google App Engine
This is Rietveld 408576698