Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2848273002: Aura-Mus: Avoid creating StubSurfaceReferenceFactory's on every surface ID change (Closed)

Created:
3 years, 7 months ago by Fady Samuel
Modified:
3 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Aura-Mus: Avoid creating StubSurfaceReferenceFactory's on every surface ID change BUG=none Review-Url: https://codereview.chromium.org/2848273002 Cr-Commit-Position: refs/heads/master@{#468411} Committed: https://chromium.googlesource.com/chromium/src/+/77654fd14e789bfa365527d2fa0d643aa29f1966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ui/aura/mus/client_surface_embedder.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/aura/mus/client_surface_embedder.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Fady Samuel
3 years, 7 months ago (2017-05-01 17:14:00 UTC) #2
sadrul
lgtm
3 years, 7 months ago (2017-05-01 19:30:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848273002/1
3 years, 7 months ago (2017-05-01 21:13:00 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 21:18:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77654fd14e789bfa365527d2fa0d...

Powered by Google App Engine
This is Rietveld 408576698