Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2848243003: cc : Replace unordered_maps with flat_map in property trees (Closed)

Created:
3 years, 7 months ago by jaydasika
Modified:
3 years, 7 months ago
Reviewers:
weiliangc, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Replace unordered_maps with flat_map in property trees Because these maps should be small. BUG=678397 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2848243003 Cr-Commit-Position: refs/heads/master@{#468403} Committed: https://chromium.googlesource.com/chromium/src/+/dfcb08fa366cfdc45f3a18e5e421a34aa038af0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M cc/trees/property_tree.h View 2 chunks +5 lines, -8 lines 0 comments Download
M cc/trees/property_tree.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jaydasika
PTAL
3 years, 7 months ago (2017-05-01 17:56:42 UTC) #3
weiliangc
LGTM
3 years, 7 months ago (2017-05-01 18:49:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848243003/1
3 years, 7 months ago (2017-05-01 20:51:38 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 20:58:44 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dfcb08fa366cfdc45f3a18e5e421...

Powered by Google App Engine
This is Rietveld 408576698