Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2848223002: Reland of Disable flaky CommandLineExtensionsDontLoad test (Closed)

Created:
3 years, 7 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 7 months ago
Reviewers:
emaxx
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable flaky CommandLineExtensionsDontLoad test (patchset #1 id:1 of https://codereview.chromium.org/2855553002/ ) Reason for revert: Build failure causing original revert seems to have been a flake. Original issue's description: > Revert of Disable flaky CommandLineExtensionsDontLoad test (patchset #1 id:1 of https://codereview.chromium.org/2852933002/ ) > > Reason for revert: > Speculatively reverting due to build failure on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/26841 > > Original issue's description: > > Disable flaky CommandLineExtensionsDontLoad test > > > > TBR=emaxx@chromium.org > > BUG=716727 > > > > Review-Url: https://codereview.chromium.org/2852933002 > > Cr-Commit-Position: refs/heads/master@{#468286} > > Committed: https://chromium.googlesource.com/chromium/src/+/91f64acccbfe592af367f79ae74649d520528f0b > > TBR=emaxx@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=716727 > > Review-Url: https://codereview.chromium.org/2855553002 > Cr-Commit-Position: refs/heads/master@{#468290} > Committed: https://chromium.googlesource.com/chromium/src/+/606b2b5d25564f187a843d25e5c2998d4ad2c04e TBR=emaxx@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=716727 Review-Url: https://codereview.chromium.org/2848223002 Cr-Commit-Position: refs/heads/master@{#468300} Committed: https://chromium.googlesource.com/chromium/src/+/78f1ed5b275c87a998bcb2c4d0d79af92316394d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
suzyh_UTC10 (ex-contributor)
Created Reland of Disable flaky CommandLineExtensionsDontLoad test
3 years, 7 months ago (2017-05-01 06:55:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848223002/1
3 years, 7 months ago (2017-05-01 06:55:25 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 06:56:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/78f1ed5b275c87a998bcb2c4d0d7...

Powered by Google App Engine
This is Rietveld 408576698