Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: net/quic/platform/api/quic_endian_test.cc

Issue 2848203002: Add a platform implementation of QuicTest and QuicTestWithParam (Closed)
Patch Set: net/quic/platform/impl/quic_test_impl.cc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/spdy_utils_test.cc ('k') | net/quic/platform/api/quic_hostname_utils_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/platform/api/quic_endian_test.cc
diff --git a/net/quic/platform/api/quic_endian_test.cc b/net/quic/platform/api/quic_endian_test.cc
index 5b63dd94efd3eaa8d4d064f40b7ff81dc79966db..02a762ab0f778b388cf37651bd656483e772924a 100644
--- a/net/quic/platform/api/quic_endian_test.cc
+++ b/net/quic/platform/api/quic_endian_test.cc
@@ -4,7 +4,7 @@
#include "net/quic/platform/api/quic_endian.h"
-#include "testing/gtest/include/gtest/gtest.h"
+#include "net/quic/platform/api/quic_test.h"
namespace net {
namespace test {
@@ -17,7 +17,9 @@ const uint32_t k32BitSwappedTestData = 0xddccbbaa;
const uint64_t k64BitTestData = 0xaabbccdd44332211;
const uint64_t k64BitSwappedTestData = 0x11223344ddccbbaa;
-TEST(QuicEndianTest, HostToNet) {
+class QuicEndianTest : public QuicTest {};
+
+TEST_F(QuicEndianTest, HostToNet) {
if (QuicEndian::HostIsLittleEndian()) {
EXPECT_EQ(k16BitSwappedTestData, QuicEndian::HostToNet16(k16BitTestData));
EXPECT_EQ(k32BitSwappedTestData, QuicEndian::HostToNet32(k32BitTestData));
@@ -29,7 +31,7 @@ TEST(QuicEndianTest, HostToNet) {
}
}
-TEST(QuicEndianTest, NetToHost) {
+TEST_F(QuicEndianTest, NetToHost) {
if (QuicEndian::HostIsLittleEndian()) {
EXPECT_EQ(k16BitTestData, QuicEndian::NetToHost16(k16BitSwappedTestData));
EXPECT_EQ(k32BitTestData, QuicEndian::NetToHost32(k32BitSwappedTestData));
« no previous file with comments | « net/quic/core/spdy_utils_test.cc ('k') | net/quic/platform/api/quic_hostname_utils_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698