Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2848193002: [ES6 modules] Enable moduleScripts under experimental-web-platform-features (Closed)

Created:
3 years, 7 months ago by kouhei (in TOK)
Modified:
3 years, 7 months ago
Reviewers:
haraken, module-dev, adamk
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ES6 modules] Enable moduleScripts under experimental-web-platform-features BUG=594639 Review-Url: https://codereview.chromium.org/2848193002 Cr-Commit-Position: refs/heads/master@{#468401} Committed: https://chromium.googlesource.com/chromium/src/+/29950db433027277a61c43d8e161a8b36f5ea0d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
kouhei (in TOK)
Discussion at https://groups.google.com/a/chromium.org/d/msg/module-dev/OW3xWHkX-gA/mJqMXxuICAAJ
3 years, 7 months ago (2017-05-01 00:50:39 UTC) #2
haraken
LGTM but please wait for an approval from modules folks.
3 years, 7 months ago (2017-05-01 00:52:55 UTC) #5
adamk
lgtm
3 years, 7 months ago (2017-05-01 17:47:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848193002/1
3 years, 7 months ago (2017-05-01 17:48:00 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 20:41:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29950db433027277a61c43d8e161...

Powered by Google App Engine
This is Rietveld 408576698