Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2848173002: 🔍 Yank out measurement logic for FirstRun pages (Closed)

Created:
3 years, 7 months ago by gone
Modified:
3 years, 7 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

🔍 Yank out measurement logic for FirstRun pages Yank out the custom logic used by the signin page for the signin page on First Run so that it can be reused for the upcoming search engine page. BUG=712836, 712833 Review-Url: https://codereview.chromium.org/2848173002 Cr-Commit-Position: refs/heads/master@{#468537} Committed: https://chromium.googlesource.com/chromium/src/+/9f6d86bb11ff6aa6754d49136f2ae053d3313fdf

Patch Set 1 #

Patch Set 2 : 🔍 Yank out measurement logic for First Run pages #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -39 lines) Patch
M chrome/android/java/res/layout/account_signin_view.xml View 1 chunk +1 line, -1 line 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunChooserView.java View 1 chunk +66 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninChooseView.java View 3 chunks +2 lines, -38 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
gone
gogerald@: I think you were the one who last dealt with this, right? PTAL?
3 years, 7 months ago (2017-04-30 20:59:48 UTC) #2
gone
Redirecting.
3 years, 7 months ago (2017-05-01 23:34:10 UTC) #4
Theresa
lgtm
3 years, 7 months ago (2017-05-02 00:24:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848173002/40001
3 years, 7 months ago (2017-05-02 00:25:42 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 02:24:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9f6d86bb11ff6aa6754d49136f2a...

Powered by Google App Engine
This is Rietveld 408576698