Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2848163002: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2848163002 Cr-Commit-Position: refs/heads/master@{#468244} Committed: https://chromium.googlesource.com/chromium/src/+/24c995b98d16db9195c48992aeecae0fd45ef576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/android/bookmarks/partner_bookmarks_shim.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/bookmarks/partner_bookmarks_shim.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/download/chrome_download_delegate.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-29 02:43:38 UTC) #4
Ted C
lgtm
3 years, 7 months ago (2017-04-29 06:11:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848163002/1
3 years, 7 months ago (2017-04-29 13:24:25 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 15:20:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/24c995b98d16db9195c48992aeec...

Powered by Google App Engine
This is Rietveld 408576698