remoting/client/ios/app/host_view_controller.h - Issue 2848143002: [Remoting iOS] Fix screen tearing and screen dimensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/ios/app/host_view_controller.h

Issue 2848143002: [Remoting iOS] Fix screen tearing and screen dimensions (Closed)

Patch Set: Add comments about not inheriting GLKViewController Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/ios/app/host_view_controller.h

diff --git a/remoting/client/ios/app/host_view_controller.h b/remoting/client/ios/app/host_view_controller.h

index ef2bb153f01e995792fbcaf01cc2db7027f539da..93a1415e14d9d0770e13ff2d1585b463f9a15a86 100644

--- a/remoting/client/ios/app/host_view_controller.h

+++ b/remoting/client/ios/app/host_view_controller.h

@@ -5,11 +5,14 @@

#ifndef REMOTING_CLIENT_IOS_APP_HOST_VIEW_CONTROLLER_H_

#define REMOTING_CLIENT_IOS_APP_HOST_VIEW_CONTROLLER_H_

-#import <GLKit/GLKit.h>

+#import <UIKit/UIKit.h>

@class RemotingClient;

-@interface HostViewController : GLKViewController

+// We don't inherit it from GLKViewController since it uses its rendering loop,

+// which will swap buffers when the GLRenderer is writing and causes screen

+// tearing issues. Instead we use GlDisplayHandler to handle the rendering loop.

+@interface HostViewController : UIViewController

- (id)initWithClient:(RemotingClient*)client;

« no previous file with comments | « no previous file | remoting/client/ios/app/host_view_controller.mm » ('j') | no next file with comments »