Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: remoting/client/ios/app/host_view_controller.h

Issue 2848143002: [Remoting iOS] Fix screen tearing and screen dimensions (Closed)
Patch Set: Add comments about not inheriting GLKViewController Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | remoting/client/ios/app/host_view_controller.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_CLIENT_IOS_APP_HOST_VIEW_CONTROLLER_H_ 5 #ifndef REMOTING_CLIENT_IOS_APP_HOST_VIEW_CONTROLLER_H_
6 #define REMOTING_CLIENT_IOS_APP_HOST_VIEW_CONTROLLER_H_ 6 #define REMOTING_CLIENT_IOS_APP_HOST_VIEW_CONTROLLER_H_
7 7
8 #import <GLKit/GLKit.h> 8 #import <UIKit/UIKit.h>
9 9
10 @class RemotingClient; 10 @class RemotingClient;
11 11
12 @interface HostViewController : GLKViewController 12 // We don't inherit it from GLKViewController since it uses its rendering loop,
13 // which will swap buffers when the GLRenderer is writing and causes screen
14 // tearing issues. Instead we use GlDisplayHandler to handle the rendering loop.
15 @interface HostViewController : UIViewController
13 16
14 - (id)initWithClient:(RemotingClient*)client; 17 - (id)initWithClient:(RemotingClient*)client;
15 18
16 @end 19 @end
17 20
18 #endif // REMOTING_CLIENT_IOS_APP_REMOTING_HOST_VIEW_CONTROLLER_H_ 21 #endif // REMOTING_CLIENT_IOS_APP_REMOTING_HOST_VIEW_CONTROLLER_H_
OLDNEW
« no previous file with comments | « no previous file | remoting/client/ios/app/host_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698