Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2848003002: Rename GoogleLandingController to GoogleLandingViewController (Closed)

Created:
3 years, 7 months ago by justincohen
Modified:
3 years, 7 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, ios-reviews+clean_chromium.org, marq+watch_chromium.org, lpromero+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename GoogleLandingController to GoogleLandingViewController BUG= Review-Url: https://codereview.chromium.org/2848003002 Cr-Commit-Position: refs/heads/master@{#468071} Committed: https://chromium.googlesource.com/chromium/src/+/f97da42cc4b51bc03f6d1fdf1a3f4ce86d97d096

Patch Set 1 #

Patch Set 2 : Missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1692 lines) Patch
M ios/chrome/app/spotlight/topsites_spotlight_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/ntp/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
D ios/chrome/browser/ui/ntp/google_landing_controller.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ios/chrome/browser/ui/ntp/google_landing_controller.mm View 1 chunk +0 lines, -1523 lines 0 comments Download
M ios/chrome/browser/ui/ntp/google_landing_controller_unittest.mm View 1 1 chunk +0 lines, -86 lines 0 comments Download
A + ios/chrome/browser/ui/ntp/google_landing_view_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + ios/chrome/browser/ui/ntp/google_landing_view_controller.mm View 10 chunks +19 lines, -19 lines 0 comments Download
A + ios/chrome/browser/ui/ntp/google_landing_view_controller_unittest.mm View 1 4 chunks +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_controller.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm View 2 chunks +7 lines, -6 lines 0 comments Download
M ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
justincohen
s/GoogleLandingController/GoogleLandingViewController/g s/google_landing_controller/google_landing_view_controller/g s/GOOGLE_LANDING_CONTROLLER/GOOGLE_LANDING_VIEW_CONTROLLER/g ptal
3 years, 7 months ago (2017-04-28 16:57:33 UTC) #2
jif
assuming it builds, lgtm.
3 years, 7 months ago (2017-04-28 17:04:04 UTC) #3
rohitrao (ping after 24h)
lgtm
3 years, 7 months ago (2017-04-28 17:09:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848003002/20001
3 years, 7 months ago (2017-04-28 17:11:44 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 18:41:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f97da42cc4b51bc03f6d1fdf1a3f...

Powered by Google App Engine
This is Rietveld 408576698