Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Issue 2847983002: Use unique_ptr for Create{ServiceWorkerNetworkProvider,ApplicationCacheHost} (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
index 90bc12be729205d5f103daca30d7ef883563577f..d63d48687962110345cda6b4d8f40534c17af1a3 100644
--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
@@ -240,10 +240,8 @@ class WebServiceWorkerContextClient {
// Ownership of the returned object is transferred to the caller.
nhiroki 2017/05/01 05:04:28 ditto.
// This is called on the main thread.
- virtual WebServiceWorkerNetworkProvider*
- CreateServiceWorkerNetworkProvider() {
- return nullptr;
- }
+ virtual std::unique_ptr<WebServiceWorkerNetworkProvider>
+ CreateServiceWorkerNetworkProvider() = 0;
// Creates a WebWorkerFetchContext for a service worker. Ownership of the
// returned object is transferred to the caller. This is called on the main
@@ -255,9 +253,8 @@ class WebServiceWorkerContextClient {
// Ownership of the returned object is transferred to the caller.
nhiroki 2017/05/01 05:04:27 ditto.
// This is called on the main thread.
- virtual WebServiceWorkerProvider* CreateServiceWorkerProvider() {
- return nullptr;
- }
+ virtual std::unique_ptr<WebServiceWorkerProvider>
+ CreateServiceWorkerProvider() = 0;
// Ownership of the passed callbacks is transferred to the callee, callee
// should delete the callbacks after calling either onSuccess or onError.

Powered by Google App Engine
This is Rietveld 408576698