Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 2847963002: [ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC. (Closed)

Created:
3 years, 7 months ago by stkhapugin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/prefs:prefs to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2847963002 Cr-Commit-Position: refs/heads/master@{#468643} Committed: https://chromium.googlesource.com/chromium/src/+/8824f0e53e5b5baf3284d3a9e80855bcdacfa2e0

Patch Set 1 #

Patch Set 2 : annotate variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ios/chrome/browser/prefs/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/prefs/pref_observer_bridge.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/prefs/pref_observer_bridge.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
stkhapugin
PTAL
3 years, 7 months ago (2017-05-02 15:19:22 UTC) #8
marq (ping after 24h)
lgtm
3 years, 7 months ago (2017-05-02 15:25:10 UTC) #9
stkhapugin
Thank you!
3 years, 7 months ago (2017-05-02 15:28:33 UTC) #10
stkhapugin
Thank you!
3 years, 7 months ago (2017-05-02 15:28:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847963002/20001
3 years, 7 months ago (2017-05-02 15:29:07 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 15:34:29 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8824f0e53e5b5baf3284d3a9e808...

Powered by Google App Engine
This is Rietveld 408576698