Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2847953002: [heap] Cleanup: Untangle marking state and deque in incremental marking (Closed)

Created:
3 years, 7 months ago by Michael Lippautz
Modified:
3 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Cleanup: Untangle marking state and deque in incremental marking BUG=v8:6325, v8:6330 Review-Url: https://codereview.chromium.org/2847953002 Cr-Commit-Position: refs/heads/master@{#44983} Committed: https://chromium.googlesource.com/v8/v8/+/df319447d45c6280e70dc38ba916946ddc96a144

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 2

Patch Set 4 : Remove unused parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -112 lines) Patch
M src/heap/heap.cc View 1 2 3 7 chunks +8 lines, -7 lines 0 comments Download
M src/heap/incremental-marking.h View 1 2 3 3 chunks +32 lines, -16 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 23 chunks +78 lines, -88 lines 0 comments Download
M src/heap/scavenger.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Michael Lippautz
PTAL https://codereview.chromium.org/2847953002/diff/40001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/2847953002/diff/40001/src/heap/heap.cc#newcode5567 src/heap/heap.cc:5567: incremental_marking_->set_marking_deque( There's a dependency of setting up spaces ...
3 years, 7 months ago (2017-04-28 12:49:41 UTC) #3
ulan
lgtm
3 years, 7 months ago (2017-04-28 12:53:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847953002/60001
3 years, 7 months ago (2017-04-28 13:02:47 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 13:33:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/df319447d45c6280e70dc38ba916946ddc9...

Powered by Google App Engine
This is Rietveld 408576698