third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html - Issue 2847943002: Cleanup LayoutTests that define a function gc().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html

Issue 2847943002: Cleanup LayoutTests that define a function gc(). (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/workers/worker-supplement-gc.html ('K') | « third_party/WebKit/LayoutTests/fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/from-disk-cache-timing.html » ('j') | third_party/WebKit/LayoutTests/media/mediasession/mojo/callback-alive-after-gc.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html

diff --git a/third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html b/third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html

index 1d27198cc1ee8a67034ae669f2da4586f473a049..b79220fca179bed7a6dd4c6fe5748cfa01ccfd71 100644

--- a/third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html

+++ b/third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html

@@ -4,21 +4,12 @@

+<script src="../resources/gc.js"></script>

Srirama 2017/04/28 09:39:55 move it above

</head>

<body>

description("Tests that we do not crash when a Geolocation request is made from a remote frame, which is then removed from the DOM in the error callback.");

-function gc() {

- if (window.GCController) {

- GCController.collect();

- return;

- }

- for (var i = 0; i < 10000; i++)

- new String(i);

function onIframeReady() {

// Make request from remote frame

iframe.contentWindow.navigator.geolocation.getCurrentPosition(function() {