Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2847923002: [Chromecast] Add method to CastCdm for the session expiration updating. (Closed)

Created:
3 years, 7 months ago by esum
Modified:
3 years, 5 months ago
Reviewers:
slan, yucliu, halliwell, yucliu1
CC:
chromium-reviews, eme-reviews_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, alokp+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Add method to CastCdm for the session expiration updating. Allows derived classes to access/run the SessionExpirationUpdateCB that gets passed in to Initialize(). This follows the same pattern as the other session callbacks in CastCdm (OnSessionClosed(), OnSessionKeysChange()). BUG= Review-Url: https://codereview.chromium.org/2847923002 Cr-Commit-Position: refs/heads/master@{#467825} Committed: https://chromium.googlesource.com/chromium/src/+/7a56b3cd2544600bce3b0f3df38eba2c06eb0dfe

Patch Set 1 #

Patch Set 2 : Add InstanceIDFactory class to help with testing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -29 lines) Patch
M chrome/browser/gcm/instance_id/instance_id_profile_service.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M components/gcm_driver/gcm_profile_service.h View 1 3 chunks +9 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_profile_service.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download
M components/gcm_driver/instance_id/BUILD.gn View 1 2 chunks +7 lines, -0 lines 0 comments Download
M components/gcm_driver/instance_id/instance_id.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M components/gcm_driver/instance_id/instance_id_android.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
A components/gcm_driver/instance_id/instance_id_android_factory.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
A components/gcm_driver/instance_id/instance_id_android_factory.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M components/gcm_driver/instance_id/instance_id_driver.h View 1 3 chunks +3 lines, -1 line 0 comments Download
M components/gcm_driver/instance_id/instance_id_driver.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M components/gcm_driver/instance_id/instance_id_driver_unittest.cc View 1 4 chunks +6 lines, -1 line 0 comments Download
A components/gcm_driver/instance_id/instance_id_factory.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
M components/gcm_driver/instance_id/instance_id_impl.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
A components/gcm_driver/instance_id/instance_id_impl_factory.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
A components/gcm_driver/instance_id/instance_id_impl_factory.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
esum
3 years, 7 months ago (2017-04-28 01:21:35 UTC) #3
yucliu1
On 2017/04/28 01:21:35, esum wrote: lgtm, thanks!
3 years, 7 months ago (2017-04-28 01:26:45 UTC) #4
slan
lgtm
3 years, 7 months ago (2017-04-28 01:27:31 UTC) #5
halliwell
On 2017/04/28 01:27:31, slan wrote: > lgtm lgtm
3 years, 7 months ago (2017-04-28 01:29:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847923002/1
3 years, 7 months ago (2017-04-28 01:34:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7a56b3cd2544600bce3b0f3df38eba2c06eb0dfe
3 years, 7 months ago (2017-04-28 01:58:28 UTC) #11
esum
3 years, 5 months ago (2017-07-15 02:29:10 UTC) #12
Message was sent while issue was closed.
On 2017/04/28 01:58:28, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/7a56b3cd2544600bce3b0f3df38e...

Please ignore Patch Set 2. I don't know what I did just now... but I did
something bad. I meant to make a new CL.

Powered by Google App Engine
This is Rietveld 408576698