cocoa: don't draw focus rings over the URL scheme in the location bar

cocoa: don't draw focus rings over the URL scheme in the location bar

The security state decoration looks like this:

  Secure |

The divider is included in the bounds, and then the location bar text is placed
just after this decoration; because of that, the focus ring on the security
state decoration (which is exterior to the decoration, like Cocoa focus rings
usually are) draws over the top of the start of the location bar text. This
change:

1) Introduces LocationBarDecoration::GetRealFocusRingBounds() to allow each
   decoration to control its focus ring bounds if it needs to
2) Overrides that method in SecurityStateBubbleDecoration to inset the focus
   ring on the right side

BUG=715909
Review-Url: https://codereview.chromium.org/2847903003
Cr-Commit-Position: refs/heads/master@{#468096}
Committed: https://chromium.googlesource.com/chromium/src/+/7d0f29cf86073f026098badc2dfe6ee7a7520b65

[Elly Fong-Jones, 2017-04-28 18:28:54]

Description was changed from

==========
cocoa: don't draw focus rings over the URL scheme in the location bar

The security state decoration looks like this:

  Secure |

The divider is included in the bounds, and then the location bar text is placed
just after this decoration; because of that, the focus ring on the security
state decoration (which is exterior to the decoration, like Cocoa focus rings
usually are) draws over the top of the start of the location bar text. This
change:

1) Introduces LocationBarDecoration::GetRealFocusRingBounds() to allow each
   decoration to control its focus ring bounds if it needs to
2) Overrides that method in SecurityStateBubbleDecoration to inset the focus
   ring on the right side

BUG=715909
==========

to

==========
cocoa: don't draw focus rings over the URL scheme in the location bar

The security state decoration looks like this:

  Secure |

The divider is included in the bounds, and then the location bar text is placed
just after this decoration; because of that, the focus ring on the security
state decoration (which is exterior to the decoration, like Cocoa focus rings
usually are) draws over the top of the start of the location bar text. This
change:

1) Introduces LocationBarDecoration::GetRealFocusRingBounds() to allow each
   decoration to control its focus ring bounds if it needs to
2) Overrides that method in SecurityStateBubbleDecoration to inset the focus
   ring on the right side

BUG=715909
==========

[Elly Fong-Jones, 2017-04-28 18:28:54]

ellyjones@chromium.org changed reviewers:
+ spqchan@chromium.org

[Elly Fong-Jones, 2017-04-28 18:28:59]

spqchan: ptal? :)

[spqchan, 2017-04-28 19:12:20]

lgtm

[Elly Fong-Jones, 2017-04-28 19:15:54]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2017-04-28 19:16:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 19:39:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493406954957790, "parent_rev":
"7dd3a05345922cb284273a33fe1acbdcbc9c82c7", "commit_rev":
"7d0f29cf86073f026098badc2dfe6ee7a7520b65"}

[commit-bot: I haz the power, 2017-04-28 19:39:53]

Description was changed from

==========
cocoa: don't draw focus rings over the URL scheme in the location bar

The security state decoration looks like this:

  Secure |

The divider is included in the bounds, and then the location bar text is placed
just after this decoration; because of that, the focus ring on the security
state decoration (which is exterior to the decoration, like Cocoa focus rings
usually are) draws over the top of the start of the location bar text. This
change:

1) Introduces LocationBarDecoration::GetRealFocusRingBounds() to allow each
   decoration to control its focus ring bounds if it needs to
2) Overrides that method in SecurityStateBubbleDecoration to inset the focus
   ring on the right side

BUG=715909
==========

to

==========
cocoa: don't draw focus rings over the URL scheme in the location bar

The security state decoration looks like this:

  Secure |

The divider is included in the bounds, and then the location bar text is placed
just after this decoration; because of that, the focus ring on the security
state decoration (which is exterior to the decoration, like Cocoa focus rings
usually are) draws over the top of the start of the location bar text. This
change:

1) Introduces LocationBarDecoration::GetRealFocusRingBounds() to allow each
   decoration to control its focus ring bounds if it needs to
2) Overrides that method in SecurityStateBubbleDecoration to inset the focus
   ring on the right side

BUG=715909

Review-Url: https://codereview.chromium.org/2847903003
Cr-Commit-Position: refs/heads/master@{#468096}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d0f29cf86073f026098badc2dfe...
==========

[commit-bot: I haz the power, 2017-04-28 19:39:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d0f29cf86073f026098badc2dfe...