Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2847893003: Support PerformanceResourceTiming for Service Worker Navigation Preload (Closed)

Created:
3 years, 7 months ago by horo
Modified:
3 years, 7 months ago
CC:
chromium-reviews, kenjibaheux+watch_chromium.org, tzik, kinuko+watch, jsbell+serviceworker_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, blink-reviews, falken+watch_chromium.org, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, panicker+watch_chromium.org, mlamouri+watch-content_chromium.org, blink-reviews-w3ctests_chromium.org, nhiroki, loading-reviews_chromium.org, haraken, loading-reviews+fetch_chromium.org, Nate Chapin, michaeln, shimazu+serviceworker_chromium.org, tyoshino+watch_chromium.org, serviceworker-reviews, kinuko+serviceworker, horo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Support PerformanceResourceTiming for Service Worker Navigation Preload BUG=712809 Review-Url: https://codereview.chromium.org/2847893003 Cr-Commit-Position: refs/heads/master@{#467979} Committed: https://chromium.googlesource.com/chromium/src/+/1b2b965b6d7588243a28803a4f5253f737e393e0

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment of SetNegativeAllowed() #

Total comments: 2

Patch Set 3 : s/timestams/timestamps/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -63 lines) Patch
M content/renderer/service_worker/service_worker_context_client.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 3 chunks +15 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/resource-timing.https.html View 1 chunk +92 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/resources/resource-timing-scope.py View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/resources/resource-timing-worker.js View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/chromium/navigation-preload-resource-timing.html View 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/chromium/resources/navigation-preload-resource-timing-scope.html View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/chromium/resources/navigation-preload-resource-timing-worker.js View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp View 12 chunks +15 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp View 13 chunks +27 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/timing/WorkerGlobalScopePerformance.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h View 5 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp View 4 chunks +38 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h View 1 2 3 chunks +16 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 5 chunks +19 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
horo
ksakamoto@ Could you please review?
3 years, 7 months ago (2017-04-28 03:02:59 UTC) #4
kinuko
lgtm (if sakamoto-san's happy) https://codereview.chromium.org/2847893003/diff/1/third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h File third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h (right): https://codereview.chromium.org/2847893003/diff/1/third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h#newcode107 third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h:107: void SetNegativeAllowed(bool negative_allowed) { nit: ...
3 years, 7 months ago (2017-04-28 08:26:27 UTC) #8
horo
Thank you. https://codereview.chromium.org/2847893003/diff/1/third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h File third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h (right): https://codereview.chromium.org/2847893003/diff/1/third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h#newcode107 third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h:107: void SetNegativeAllowed(bool negative_allowed) { On 2017/04/28 08:26:27, ...
3 years, 7 months ago (2017-04-28 08:48:10 UTC) #11
horo
Thank you. https://codereview.chromium.org/2847893003/diff/1/third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h File third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h (right): https://codereview.chromium.org/2847893003/diff/1/third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h#newcode107 third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h:107: void SetNegativeAllowed(bool negative_allowed) { On 2017/04/28 08:26:27, ...
3 years, 7 months ago (2017-04-28 08:48:11 UTC) #12
Kunihiko Sakamoto
lgtm It's interesting that ResourceTiming for navigation preload can have negative fields! Commented at https://github.com/w3c/resource-timing/issues/88 ...
3 years, 7 months ago (2017-04-28 11:49:00 UTC) #15
horo
Thank you. https://codereview.chromium.org/2847893003/diff/20001/third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h File third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h (right): https://codereview.chromium.org/2847893003/diff/20001/third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h#newcode107 third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h:107: // The timestams in PerformanceResourceTiming are measured ...
3 years, 7 months ago (2017-04-28 11:56:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847893003/40001
3 years, 7 months ago (2017-04-28 11:57:00 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1b2b965b6d7588243a28803a4f5253f737e393e0
3 years, 7 months ago (2017-04-28 13:34:35 UTC) #22
panicker
3 years, 7 months ago (2017-04-28 18:02:46 UTC) #23
Message was sent while issue was closed. 
On 2017/04/28 11:49:00, ksakamoto (Apr 29 - May 7 ooo) wrote:
> lgtm
> 
> It's interesting that ResourceTiming for navigation preload can have negative
> fields! Commented at https://github.com/w3c/resource-timing/issues/88 to make
> sure spec authors are aware of this.
Thanks for raising this, could you file a new bug on the spec for this?
(My understanding from past conversations is that DomHighResTimestamp should not
be negative)

> 
>
https://codereview.chromium.org/2847893003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h
> (right):
> 
>
https://codereview.chromium.org/2847893003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h:107: //
The
> timestams in PerformanceResourceTiming are measured relative from the
> timestams -> timestamps

Powered by Google App Engine
This is Rietveld 408576698